Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-08 Thread Gerd Hoffmann
Hi, > > The design idea is to reuse the request serialization protocol edk2 uses > > I suppose this is a stable protocol. (some parts are set by the UEFI > spec probably) Partly yes, partly this is edk2-internal stuff. In theory there is some freedom to change the internal parts, in practice

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-08 Thread Gerd Hoffmann
Hi, > > Typically the kind of new code that I wish would be in Rust. But I > > suppose it is too early yet, and you came to the same conclusion. > > Probably a good candidate for rewrite though! > > Perhaps too early for the device impl, but I would have thought > the general var-service code c

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-08 Thread Daniel P . Berrangé
On Wed, Jan 08, 2025 at 03:53:21PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 7, 2025 at 7:34 PM Gerd Hoffmann wrote: > > > > This patch adds a virtual device to qemu which the uefi firmware can use > > to store variables. This moves the UEFI variable management from > > privileged gue

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-08 Thread Marc-André Lureau
Hi On Tue, Jan 7, 2025 at 7:34 PM Gerd Hoffmann wrote: > > This patch adds a virtual device to qemu which the uefi firmware can use > to store variables. This moves the UEFI variable management from > privileged guest code (managing vars in pflash) to the host. Main > advantage is that the need

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-07 Thread Gerd Hoffmann
Hi, > > The design idea is to reuse the request serialization protocol edk2 uses > > for communication between SMM and non-SMM code, so large chunks of the > > edk2 variable driver stack can be used unmodified. Only the driver > > which traps into SMM mode must be replaced by a driver which tal

Re: [PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-07 Thread Daniel P . Berrangé
On Tue, Jan 07, 2025 at 04:33:27PM +0100, Gerd Hoffmann wrote: > This patch adds a virtual device to qemu which the uefi firmware can use > to store variables. This moves the UEFI variable management from > privileged guest code (managing vars in pflash) to the host. Main > advantage is that the

[PATCH v2 00/21] hw/uefi: add uefi variable service

2025-01-07 Thread Gerd Hoffmann
This patch adds a virtual device to qemu which the uefi firmware can use to store variables. This moves the UEFI variable management from privileged guest code (managing vars in pflash) to the host. Main advantage is that the need to have privilege separation in the guest goes away. On x86 privi