Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-19 Thread Andre Przywara
On Wed, 19 Jan 2022 10:15:52 + Peter Maydell wrote: Hi Peter, > On Tue, 18 Jan 2022 at 23:30, Andre Przywara wrote: > > Looking at k-u-t's arm/gic.c and QEMU's hw/intc/arm_gic.c I see two > > problems here: QEMU implements word accesses as four successive calls to > > gic_dist_readb() - whi

Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-19 Thread Peter Maydell
On Tue, 18 Jan 2022 at 23:30, Andre Przywara wrote: > Looking at k-u-t's arm/gic.c and QEMU's hw/intc/arm_gic.c I see two > problems here: QEMU implements word accesses as four successive calls to > gic_dist_readb() - which is probably fine if that helps code design, > but it won't allow it to act

Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-18 Thread Andre Przywara
On Tue, 18 Jan 2022 19:41:56 + Peter Maydell wrote: Hi Peter, Alex, thanks for the heads up! > On Tue, 18 Jan 2022 at 17:42, Alex Bennée wrote: > > > > > > Peter Maydell writes: > > > > > I've been working on the ITS to add support for the GICv4 functionality. > > > In the course of tha

Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-18 Thread Peter Maydell
On Tue, 18 Jan 2022 at 17:42, Alex Bennée wrote: > > > Peter Maydell writes: > > > I've been working on the ITS to add support for the GICv4 functionality. > > In the course of that I found a handful of bugs in it and also some > > places where the code benefited from refactoring to make it a bet

Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-18 Thread Alex Bennée
Peter Maydell writes: > I've been working on the ITS to add support for the GICv4 functionality. > In the course of that I found a handful of bugs in it and also some > places where the code benefited from refactoring to make it a better > base to put in the GICv4 parts. This patchset is just t

[PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-11 Thread Peter Maydell
I've been working on the ITS to add support for the GICv4 functionality. In the course of that I found a handful of bugs in it and also some places where the code benefited from refactoring to make it a better base to put in the GICv4 parts. This patchset is just the bugfixes and cleanups, because