Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-10 Thread John Snow
On Mon, May 8, 2023 at 11:16 AM Stefan Hajnoczi wrote: > > On Mon, May 08, 2023 at 03:28:04PM +0200, Mads Ynddal wrote: > > > > > A question for you: do you think it's possible to move simpletrace into > > > qemu/python/utils? This requires cleaning up the code to some fairly > > > pedantic stan

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-09 Thread Stefan Hajnoczi
On Mon, May 08, 2023 at 06:50:58PM +0200, Mads Ynddal wrote: > > > > > I was curious how Mads is using simpletrace for an internal (to > > Samsung?) project. > > > > I was just tracing the NVMe emulation to get some metrics. The code is all > upstream or a part of this patchset. The rest is tra

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-08 Thread Mads Ynddal
> > I was curious how Mads is using simpletrace for an internal (to > Samsung?) project. > I was just tracing the NVMe emulation to get some metrics. The code is all upstream or a part of this patchset. The rest is tracing configs.

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-08 Thread Stefan Hajnoczi
On Mon, May 08, 2023 at 03:28:04PM +0200, Mads Ynddal wrote: > > > A question for you: do you think it's possible to move simpletrace into > > qemu/python/utils? This requires cleaning up the code to some fairly > > pedantic standards, but helps protect it against rot as we change target > > py

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-08 Thread Stefan Hajnoczi
On Thu, May 04, 2023 at 01:53:38PM -0400, John Snow wrote: > On Thu, May 4, 2023, 1:48 PM Stefan Hajnoczi wrote: > > > On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote: > > > From: Mads Ynddal > > > > > > I wanted to use simpletrace.py for an internal project, so I tried to > > update

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-08 Thread Mads Ynddal
> A question for you: do you think it's possible to move simpletrace into > qemu/python/utils? This requires cleaning up the code to some fairly pedantic > standards, but helps protect it against rot as we change target python > versions. > > No problem if that's too much to ask. just want t

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-04 Thread John Snow
On Thu, May 4, 2023, 1:48 PM Stefan Hajnoczi wrote: > On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote: > > From: Mads Ynddal > > > > I wanted to use simpletrace.py for an internal project, so I tried to > update > > and polish the code. Some of the commits resolve specific issues, wh

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-04 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > I wanted to use simpletrace.py for an internal project, so I tried to update > and polish the code. Some of the commits resolve specific issues, while some > are more subjective. An internal project based on qem

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-03 Thread John Snow
On Tue, May 2, 2023, 5:24 AM Mads Ynddal wrote: > From: Mads Ynddal > > I wanted to use simpletrace.py for an internal project, so I tried to > update > and polish the code. Some of the commits resolve specific issues, while > some > are more subjective. > > I've tried to divide it into commits

[PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-02 Thread Mads Ynddal
From: Mads Ynddal I wanted to use simpletrace.py for an internal project, so I tried to update and polish the code. Some of the commits resolve specific issues, while some are more subjective. I've tried to divide it into commits so we can discuss the individual changes, and I'm ready to pull th