Re: [PATCH v2 0/7] semihosting: proper QEMU exit on semihosted exit syscall

2022-06-22 Thread Luc Michel
On 07:37 Tue 21 Jun , Richard Henderson wrote: > On 6/21/22 05:59, Luc Michel wrote: > > v2: > >- fix linux-user compilation. Declare semihosting_exit_request "static > > inline G_NORETURN" on CONFIG_USER_ONLY side. Use > > g_assert_not_reached() to enforce the G_NORETURN since th

Re: [PATCH v2 0/7] semihosting: proper QEMU exit on semihosted exit syscall

2022-06-21 Thread Richard Henderson
On 6/21/22 05:59, Luc Michel wrote: v2: - fix linux-user compilation. Declare semihosting_exit_request "static inline G_NORETURN" on CONFIG_USER_ONLY side. Use g_assert_not_reached() to enforce the G_NORETURN since this function is unused in linux-user mode. Not true. It *is*

[PATCH v2 0/7] semihosting: proper QEMU exit on semihosted exit syscall

2022-06-21 Thread Luc Michel
v2: - fix linux-user compilation. Declare semihosting_exit_request "static inline G_NORETURN" on CONFIG_USER_ONLY side. Use g_assert_not_reached() to enforce the G_NORETURN since this function is unused in linux-user mode. - do not call gdb_exit() in semihosting_exit_request() as it