Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2023-02-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 15/2/23 14:28, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: "Michael S. Tsirkin" writes: [...] > It would be even better if there was e.g. a make target > pu

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 14:28, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: Bernhard Beschow writes: Am 22. Dezember 2022 10:03

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2023-02-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: >> >> Bernhard Beschow writes: >> >> >> >> > Am 22. Dezember 2022 10:03:23 UTC schrieb M

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-24 Thread Michael S. Tsirkin
On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: > >> Bernhard Beschow writes: > >> > >> > Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster > >> > : > >> >>Back

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-23 Thread Bernhard Beschow
Am 23. Dezember 2022 05:27:07 UTC schrieb Markus Armbruster : >"Michael S. Tsirkin" writes: > >> On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: >>> Bernhard Beschow writes: >>> >>> > Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster >>> > : >>> >>Back in 2016, w

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-22 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: >> Bernhard Beschow writes: >> >> > Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster >> > : >> >>Back in 2016, we discussed[1] rules for headers, and these were >> >>generally liked: >>

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-22 Thread Michael S. Tsirkin
On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: > Bernhard Beschow writes: > > > Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster > > : > >>Back in 2016, we discussed[1] rules for headers, and these were > >>generally liked: > >> > >>1. Have a carefully curated head

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-22 Thread Markus Armbruster
Bernhard Beschow writes: > Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster > : >>Back in 2016, we discussed[1] rules for headers, and these were >>generally liked: >> >>1. Have a carefully curated header that's included everywhere first. We >> got that already thanks to Peter: osd

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-22 Thread Bernhard Beschow
Am 22. Dezember 2022 10:03:23 UTC schrieb Markus Armbruster : >Back in 2016, we discussed[1] rules for headers, and these were >generally liked: > >1. Have a carefully curated header that's included everywhere first. We > got that already thanks to Peter: osdep.h. > >2. Headers should normall

[PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

2022-12-22 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need