Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Michael S. Tsirkin
On Thu, Jun 25, 2020 at 02:23:28PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 25, 2020 at 09:18:51AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jun 24, 2020 at 12:49:15PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > > > Also

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 09:18:51AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 24, 2020 at 12:49:15PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > > Also there is a problem with the virtio spec and Linux Kernel > > > implementation, t

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Michael S. Tsirkin
On Wed, Jun 24, 2020 at 12:49:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > Also there is a problem with the virtio spec and Linux Kernel > > implementation, the order of fields in virtio_console_resize struct > > differs between the ker

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Szymon Lukasz
On Wed, Jun 24, 2020 at 12:56:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > In this series resize notifications are only supported for the stdio > > backend but I think it should be easy to add support for the vc backend. > > Support for

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-25 Thread Szymon Lukasz
On Wed, Jun 24, 2020 at 12:49:15PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > > Also there is a problem with the virtio spec and Linux Kernel > > implementation, the order of fields in virtio_console_resize struct > > differs between the kern

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-24 Thread Daniel P . Berrangé
On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > In this series resize notifications are only supported for the stdio > backend but I think it should be easy to add support for the vc backend. > Support for tty/serial backends is complicated by the fact that there is > no clean way

Re: [PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-24 Thread Daniel P . Berrangé
On Wed, Jun 24, 2020 at 01:26:34PM +0200, Szymon Lukasz wrote: > Also there is a problem with the virtio spec and Linux Kernel > implementation, the order of fields in virtio_console_resize struct > differs between the kernel and the spec. I do not know if there is any > implementation of the virti

[PATCH v2 0/6] virtio-console: notify about the terminal size

2020-06-24 Thread Szymon Lukasz
The goal of this series is to have a resizable terminal into a guest without having to set up networking and using, e.g. ssh. The virtio spec allows a virtio-console device to notify the guest about terminal resizes in the host. Linux Kernel implements the driver part of the spec. This series impl