Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-24 Thread Peter Xu
On Thu, Oct 24, 2019 at 01:49:11PM -0400, John Snow wrote: > > > On 10/23/19 4:17 AM, Kevin Wolf wrote: > > The important difference here is legacy IDE (which works) vs. AHCI > > (which doesn't work). If you add a -device ahci to the -M pc case, it > > starts failing, too. > > > > Not sure why A

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-24 Thread John Snow
On 10/23/19 4:17 AM, Kevin Wolf wrote: > The important difference here is legacy IDE (which works) vs. AHCI > (which doesn't work). If you add a -device ahci to the -M pc case, it > starts failing, too. > > Not sure why AHCI fails, but I'll just CC John who is the lucky > maintainer of this dev

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Peter Xu
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > v2: > > > - use uint32_t rather than int64_t [Juan] > > > - one more patch (patch 4) to check dup SaveStat

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Kevin Wolf
Am 23.10.2019 um 09:57 hat Peter Xu geschrieben: > On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > > v2: > > > > - use uint32_t rather than int64_t [J

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-23 Thread Peter Xu
On Sat, Oct 19, 2019 at 11:41:53AM +0800, Peter Xu wrote: > On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > > v2: > > > - use uint32_t rather than int64_t [Juan] > > > - one more patch (patch 4) to check dup SaveStat

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-18 Thread Peter Xu
On Wed, Oct 16, 2019 at 11:40:01AM -0300, Eduardo Habkost wrote: > On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > > v2: > > - use uint32_t rather than int64_t [Juan] > > - one more patch (patch 4) to check dup SaveStateEntry [Dave] > > - one more patch to define a macro (patch 1) to si

Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-16 Thread Eduardo Habkost
On Wed, Oct 16, 2019 at 10:29:29AM +0800, Peter Xu wrote: > v2: > - use uint32_t rather than int64_t [Juan] > - one more patch (patch 4) to check dup SaveStateEntry [Dave] > - one more patch to define a macro (patch 1) to simplify patch 2 > > Please review, thanks. I wonder how hard it is to writ

[PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus

2019-10-15 Thread Peter Xu
v2: - use uint32_t rather than int64_t [Juan] - one more patch (patch 4) to check dup SaveStateEntry [Dave] - one more patch to define a macro (patch 1) to simplify patch 2 Please review, thanks. Peter Xu (4): migration: Define VMSTATE_INSTANCE_ID_ANY migration: Change SaveStateEntry.instance