Re: [PATCH v2 0/4] Clean up includes

2023-01-07 Thread Michael S. Tsirkin
On Thu, Dec 22, 2022 at 01:08:09PM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers shoul

Re: [PATCH v2 0/4] Clean up includes

2023-01-04 Thread Michael S. Tsirkin
On Thu, Dec 22, 2022 at 01:08:09PM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers shoul

[PATCH v2 0/4] Clean up includes

2022-12-22 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need

Re: [PATCH v2 0/4] Clean up includes

2022-12-22 Thread Markus Armbruster
Michael, I forgot to add your R-bys. I'll fix that in the next revision if I need one, else in the pull request.