Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-12-11 Thread Michael S. Tsirkin
On Tue, Nov 19, 2019 at 06:50:03PM -0600, Michael Roth wrote: > Currently the SLOF firmware for pseries guests will disable/re-enable > a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND > register after the initial probe/feature negotiation, as it tends to > work with a single devic

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-12-04 Thread Alexey Kardashevskiy
Hi, I was wondering if this is going anywhere or if SLOF is still expected to get fixed and if it is SLOF, then what exactly in SLOF's behaviour is incorrect and requires fixing? I am a bit lost here. Thanks, On 20/11/2019 11:50, Michael Roth wrote: > Currently the SLOF firmware for pseries gu

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-29 Thread Halil Pasic
On Thu, 28 Nov 2019 12:03:01 -0500 "Michael S. Tsirkin" wrote: [..] > > > > But it keeps nagging me, is it really OK for the device to access the > > virtio ring during reset? My intuition tells me that the device should > > not look for new requests after it has been told to reset. > > > Wel

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-28 Thread Halil Pasic
On Tue, 19 Nov 2019 18:50:03 -0600 Michael Roth wrote: [..] > I.e. the calling code is only scheduling a one-shot BH for > virtio_blk_data_plane_stop_bh, but somehow we end up trying to process > an additional virtqueue entry before we get there. This is likely due > to the following check in vir

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-28 Thread Michael S. Tsirkin
On Thu, Nov 28, 2019 at 05:48:00PM +0100, Halil Pasic wrote: > On Tue, 19 Nov 2019 18:50:03 -0600 > Michael Roth wrote: > > [..] > > I.e. the calling code is only scheduling a one-shot BH for > > virtio_blk_data_plane_stop_bh, but somehow we end up trying to process > > an additional virtqueue en

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-20 Thread Dr. David Alan Gilbert
* Michael Roth (mdr...@linux.vnet.ibm.com) wrote: > Quoting no-re...@patchew.org (2019-11-20 00:12:11) > > Patchew URL: > > https://patchew.org/QEMU/20191120005003.27035-1-mdr...@linux.vnet.ibm.com/ > > > > > > > > Hi, > > > > This series failed the docker-quick@centos7 build test. Please find

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-20 Thread Michael Roth
Quoting no-re...@patchew.org (2019-11-20 00:12:11) > Patchew URL: > https://patchew.org/QEMU/20191120005003.27035-1-mdr...@linux.vnet.ibm.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docke

Re: [PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191120005003.27035-1-mdr...@linux.vnet.ibm.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BE

[PATCH v2] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-19 Thread Michael Roth
Currently the SLOF firmware for pseries guests will disable/re-enable a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND register after the initial probe/feature negotiation, as it tends to work with a single device at a time at various stages like probing and running block/network b