Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Eric Auger
Auger >>> Cc: Duan, Zhenzhong ; qemu- >>> de...@nongnu.org; m...@redhat.com >>> Subject: Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request >>> >>> On Wed, Jun 22, 2022 at 02:22:18PM +0200, Eric Auger wrote: >>>>>>

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Jean-Philippe Brucker
dhat.com > >Subject: Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request > > > >On Wed, Jun 22, 2022 at 02:22:18PM +0200, Eric Auger wrote: > >> >> the spec is pretty confusing here though (virtio-v1.2-csd01.pdf) as > >> >> it pres

RE: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Duan, Zhenzhong
>-Original Message- >From: Jean-Philippe Brucker >Sent: Wednesday, June 22, 2022 9:58 PM >To: Eric Auger >Cc: Duan, Zhenzhong ; qemu- >de...@nongnu.org; m...@redhat.com >Subject: Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request > >On Wed,

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Jean-Philippe Brucker
On Wed, Jun 22, 2022 at 02:22:18PM +0200, Eric Auger wrote: > >> the spec is pretty confusing here though (virtio-v1.2-csd01.pdf) as it > >> presents the struct as follows: > >> > >> struct virtio_iommu_req_probe { > >> struct virtio_iommu_req_head head; > >> /* Device-readable */ > >> le32 endpoin

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Eric Auger
On 6/22/22 13:55, Jean-Philippe Brucker wrote: > Hi, > > On Wed, Jun 22, 2022 at 12:20:45PM +0200, Eric Auger wrote: >> Hi, >> >> On 6/17/22 08:20, Zhenzhong Duan wrote: >>> The structure of probe request doesn't include the tail, this leads >>> to a few field missed to be copied. Currently this

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Jean-Philippe Brucker
Hi, On Wed, Jun 22, 2022 at 12:20:45PM +0200, Eric Auger wrote: > Hi, > > On 6/17/22 08:20, Zhenzhong Duan wrote: > > The structure of probe request doesn't include the tail, this leads > > to a few field missed to be copied. Currently this isn't an issue as > > those missed field belong to reser

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-22 Thread Eric Auger
Hi, On 6/17/22 08:20, Zhenzhong Duan wrote: > The structure of probe request doesn't include the tail, this leads > to a few field missed to be copied. Currently this isn't an issue as > those missed field belong to reserved field, just in case reserved > field will be used in the future. > > Fixe

[PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-16 Thread Zhenzhong Duan
The structure of probe request doesn't include the tail, this leads to a few field missed to be copied. Currently this isn't an issue as those missed field belong to reserved field, just in case reserved field will be used in the future. Fixes: 1733eebb9e75b ("virtio-iommu: Implement RESV_MEM prob