Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-05 Thread Stefan Hajnoczi
On Thu, Mar 04, 2021 at 06:11:26PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Wed, Mar 03, 2021 at 05:01:05PM -0500, Michael S. Tsirkin wrote: > >> On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: > >> Also, are we sure it's ok to send the messages and then send >

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-04 Thread Alex Bennée
Stefan Hajnoczi writes: > On Wed, Mar 03, 2021 at 05:01:05PM -0500, Michael S. Tsirkin wrote: >> On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: >> Also, are we sure it's ok to send the messages and then send >> VHOST_USER_SET_FEATURES with VHOST_USER_F_PROTOCOL_FEATURES clear? >>

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-04 Thread Stefan Hajnoczi
On Wed, Mar 03, 2021 at 05:01:05PM -0500, Michael S. Tsirkin wrote: > On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: > Also, are we sure it's ok to send the messages and then send > VHOST_USER_SET_FEATURES with VHOST_USER_F_PROTOCOL_FEATURES clear? > Looks more like a violation to me

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-04 Thread Alex Bennée
Michael S. Tsirkin writes: > On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: >> Make the language about feature negotiation explicitly clear about the >> handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and >> avoid the sort of bug introduced in vhost.rs REPLY_ACK pr

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: > Make the language about feature negotiation explicitly clear about the > handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and > avoid the sort of bug introduced in vhost.rs REPLY_ACK processing: > > https://github.com/

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-03 Thread Stefan Hajnoczi
On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: > Make the language about feature negotiation explicitly clear about the > handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and > avoid the sort of bug introduced in vhost.rs REPLY_ACK processing: > > https://github.com/

[PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-03 Thread Alex Bennée
Make the language about feature negotiation explicitly clear about the handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and avoid the sort of bug introduced in vhost.rs REPLY_ACK processing: https://github.com/rust-vmm/vhost/pull/24 Signed-off-by: Alex Bennée Cc: Jiang Liu Mess