Re: [PATCH v2] trace/simple: Fix unauthorized enable

2020-06-17 Thread Stefan Hajnoczi
On Wed, May 27, 2020 at 08:56:13AM +0200, Markus Armbruster wrote: > st_set_trace_file() accidentally enables tracing. It's called > unconditionally during startup, which is why QEMU built with the > simple trace backend always writes a trace file "trace-$PID". > > This has been broken for quite

Re: [PATCH v2] trace/simple: Fix unauthorized enable

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 8:56 AM, Markus Armbruster wrote: > st_set_trace_file() accidentally enables tracing. It's called > unconditionally during startup, which is why QEMU built with the > simple trace backend always writes a trace file "trace-$PID". > > This has been broken for quite a while. I didn't tra

[PATCH v2] trace/simple: Fix unauthorized enable

2020-05-26 Thread Markus Armbruster
st_set_trace_file() accidentally enables tracing. It's called unconditionally during startup, which is why QEMU built with the simple trace backend always writes a trace file "trace-$PID". This has been broken for quite a while. I didn't track down the exact commit. Fix st_set_trace_file() to r