Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-05-05 Thread Fabiano Rosas
Thomas Huth writes: > From: Thomas Huth > > The logic in the qvirtio_read/write function is rather a headache, > involving byte-swapping when the target is big endian, just to > maybe involve another byte-swapping in the qtest_read/write > function immediately afterwards (on the QEMU side). Let

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Alex Bennée
Thomas Huth writes: > From: Thomas Huth > > The logic in the qvirtio_read/write function is rather a headache, > involving byte-swapping when the target is big endian, just to > maybe involve another byte-swapping in the qtest_read/write > function immediately afterwards (on the QEMU side). Let

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Thomas Huth
On 30/04/2025 15.50, Philippe Mathieu-Daudé wrote: On 30/4/25 15:28, Thomas Huth wrote: From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping  in the qtest_read/wri

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Philippe Mathieu-Daudé
On 30/4/25 15:28, Thomas Huth wrote: From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side

[PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Thomas Huth
From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side). Let's do it in a more obvious way he