Re: [PATCH v2] target/riscv: csr: Remove redundant check in fp csr read/write routines

2021-07-02 Thread Alistair Francis
On Sun, Jun 27, 2021 at 10:06 PM Bin Meng wrote: > > The following check: > > if (!env->debugger && !riscv_cpu_fp_enabled(env)) { > return -RISCV_EXCP_ILLEGAL_INST; > } > > is redundant in fflags/frm/fcsr read/write routines, as the check was > already done in fs(). > > Signed-off-

[PATCH v2] target/riscv: csr: Remove redundant check in fp csr read/write routines

2021-06-27 Thread Bin Meng
The following check: if (!env->debugger && !riscv_cpu_fp_enabled(env)) { return -RISCV_EXCP_ILLEGAL_INST; } is redundant in fflags/frm/fcsr read/write routines, as the check was already done in fs(). Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v2: - r