Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Philippe Mathieu-Daudé
On 22/12/22 13:32, Stefan Weil wrote: Am 22.12.22 um 12:51 schrieb Philippe Mathieu-Daudé: On 22/12/22 12:18, Eric Auger wrote: Hi All, On 12/22/22 12:09, Daniel P. Berrangé wrote: On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Stefan Weil via
Am 22.12.22 um 12:51 schrieb Philippe Mathieu-Daudé: On 22/12/22 12:18, Eric Auger wrote: Hi All, On 12/22/22 12:09, Daniel P. Berrangé wrote: On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: On 22/12/22 09:18, Paolo

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Philippe Mathieu-Daudé
On 22/12/22 12:18, Eric Auger wrote: Hi All, On 12/22/22 12:09, Daniel P. Berrangé wrote: On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: On 22/12/22 09:18, Paolo Bonzini wrote: On 12/21/22 17:36, Eric Auger wrote: T

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Eric Auger
Hi All, On 12/22/22 12:09, Daniel P. Berrangé wrote: > On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: >> Hi Philippe, >> >> On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: >>> On 22/12/22 09:18, Paolo Bonzini wrote: On 12/21/22 17:36, Eric Auger wrote: > To avoid compilation

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Daniel P . Berrangé
On Thu, Dec 22, 2022 at 11:07:31AM +0100, Eric Auger wrote: > Hi Philippe, > > On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: > > On 22/12/22 09:18, Paolo Bonzini wrote: > >> On 12/21/22 17:36, Eric Auger wrote: > >>> To avoid compilation errors when -Werror=maybe-uninitialized is used, > >>> re

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Bernhard Beschow
Am 22. Dezember 2022 09:01:34 UTC schrieb "Philippe Mathieu-Daudé" : >On 22/12/22 09:18, Paolo Bonzini wrote: >> On 12/21/22 17:36, Eric Auger wrote: >>> To avoid compilation errors when -Werror=maybe-uninitialized is used, >>> replace 'case 3' by 'default'. >>> >>> Otherwise we get: >>> >>>

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Philippe Mathieu-Daudé
On 22/12/22 11:07, Eric Auger wrote: Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: On 22/12/22 09:18, Paolo Bonzini wrote: On 12/21/22 17:36, Eric Auger wrote: To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we ge

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Eric Auger
Hi Philippe, On 12/22/22 10:01, Philippe Mathieu-Daudé wrote: > On 22/12/22 09:18, Paolo Bonzini wrote: >> On 12/21/22 17:36, Eric Auger wrote: >>> To avoid compilation errors when -Werror=maybe-uninitialized is used, >>> replace 'case 3' by 'default'. >>> >>> Otherwise we get: >>> >>> ../target/i

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Philippe Mathieu-Daudé
On 22/12/22 09:18, Paolo Bonzini wrote: On 12/21/22 17:36, Eric Auger wrote: To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we get: ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: erro

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-22 Thread Paolo Bonzini
On 12/21/22 17:36, Eric Auger wrote: To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we get: ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in this

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-21 Thread Stefan Weil via
Am 21.12.22 um 17:36 schrieb Eric Auger: To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we get: ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in

[PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2022-12-21 Thread Eric Auger
To avoid compilation errors when -Werror=maybe-uninitialized is used, replace 'case 3' by 'default'. Otherwise we get: ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in this function [-Werror=maybe-uninitialized]