Re: [PATCH v2] target/arm: Merge arm_cpu_vq_map_next_smaller into sole caller

2019-11-18 Thread Richard Henderson
On 11/18/19 8:58 AM, Andrew Jones wrote: > On Sat, Nov 16, 2019 at 12:06:42PM +0100, Richard Henderson wrote: >> Coverity reports, in sve_zcr_get_valid_len, >> >> "Subtract operation overflows on operands >> arm_cpu_vq_map_next_smaller(cpu, start_vq + 1U) and 1U" >> >> First, the aarch32 stub versi

Re: [PATCH v2] target/arm: Merge arm_cpu_vq_map_next_smaller into sole caller

2019-11-17 Thread Andrew Jones
On Sat, Nov 16, 2019 at 12:06:42PM +0100, Richard Henderson wrote: > Coverity reports, in sve_zcr_get_valid_len, > > "Subtract operation overflows on operands > arm_cpu_vq_map_next_smaller(cpu, start_vq + 1U) and 1U" > > First, the aarch32 stub version of arm_cpu_vq_map_next_smaller, > returning

[PATCH v2] target/arm: Merge arm_cpu_vq_map_next_smaller into sole caller

2019-11-16 Thread Richard Henderson
Coverity reports, in sve_zcr_get_valid_len, "Subtract operation overflows on operands arm_cpu_vq_map_next_smaller(cpu, start_vq + 1U) and 1U" First, the aarch32 stub version of arm_cpu_vq_map_next_smaller, returning 0, does exactly what Coverity reports. Remove it. Second, the aarch64 version o