Re: [PATCH v2] spapr: Fix Coverity warning while validating nvdimm options

2020-02-27 Thread David Gibson
On Thu, Feb 27, 2020 at 07:42:49AM -0600, Shivaprasad G Bhat wrote: > Fixes Coverity issue, > CID 1419883: Error handling issues (CHECKED_RETURN) >Calling "qemu_uuid_parse" without checking return value > > nvdimm_set_uuid() already verifies if the user provided uuid is valid o

Re: [PATCH v2] spapr: Fix Coverity warning while validating nvdimm options

2020-02-27 Thread Greg Kurz
On Thu, 27 Feb 2020 07:42:49 -0600 Shivaprasad G Bhat wrote: > Fixes Coverity issue, > CID 1419883: Error handling issues (CHECKED_RETURN) >Calling "qemu_uuid_parse" without checking return value > > nvdimm_set_uuid() already verifies if the user provided uuid is valid or > n

[PATCH v2] spapr: Fix Coverity warning while validating nvdimm options

2020-02-27 Thread Shivaprasad G Bhat
Fixes Coverity issue, CID 1419883: Error handling issues (CHECKED_RETURN) Calling "qemu_uuid_parse" without checking return value nvdimm_set_uuid() already verifies if the user provided uuid is valid or not. So, need to check for the validity during pre-plug validation again. A