Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-21 Thread Eric Blake
On 9/17/20 5:19 AM, Max Reitz wrote: temporary over NBD, referring to a bitmap that lives only in Active is less effort than having to copy a bitmap into temporary [1].  So the testsuite additions in this patch check both where bitmaps get allocated (the qemu-img info output), and, when NOT usin

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-17 Thread Max Reitz
On 15.09.20 15:31, Eric Blake wrote: > On 9/15/20 3:57 AM, Max Reitz wrote: >> On 14.09.20 21:10, Eric Blake wrote: >>> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a >>> bitmap from top into base, qemu-img was failing with: >>> >>> qemu-img: Could not open 'top.qcow2': Could n

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-16 Thread Vladimir Sementsov-Ogievskiy
14.09.2020 22:10, Eric Blake wrote: If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lock Is another process using the image [

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-16 Thread Eric Blake
On 9/15/20 3:57 AM, Max Reitz wrote: On 14.09.20 21:10, Eric Blake wrote: If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lo

Re: [PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-15 Thread Max Reitz
On 14.09.20 21:10, Eric Blake wrote: > If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a > bitmap from top into base, qemu-img was failing with: > > qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to > get shared "write" lock > Is another process using

[PATCH v2] qemu-img: Support bitmap --merge into backing image

2020-09-14 Thread Eric Blake
If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a bitmap from top into base, qemu-img was failing with: qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to get shared "write" lock Is another process using the image [base.qcow2]? The easiest fix is to no