Re: [PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-16 Thread Alberto Garcia
On Thu 16 Jan 2020 01:19:34 PM CET, Max Reitz wrote: > On 15.01.20 14:56, Alberto Garcia wrote: >> This is a bit more efficient than having to allocate and free memory >> for each item. >> >> The default size (60) is enough for all the existing incompatible >> features or the "Unknown incompatible

Re: [PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-16 Thread Max Reitz
On 15.01.20 14:56, Alberto Garcia wrote: > This is a bit more efficient than having to allocate and free memory > for each item. > > The default size (60) is enough for all the existing incompatible > features or the "Unknown incompatible feature" message. That doesn’t make sense to me. The exis

Re: [PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-16 Thread Stefano Garzarella
On Wed, Jan 15, 2020 at 02:56:26PM +0100, Alberto Garcia wrote: > This is a bit more efficient than having to allocate and free memory > for each item. > > The default size (60) is enough for all the existing incompatible > features or the "Unknown incompatible feature" message. > > Suggested-by:

Re: [PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-15 Thread Philippe Mathieu-Daudé
On 1/15/20 2:56 PM, Alberto Garcia wrote: This is a bit more efficient than having to allocate and free memory for each item. The default size (60) is enough for all the existing incompatible features or the "Unknown incompatible feature" message. Suggested-by: Philippe Mathieu-Daudé Signed-of

[PATCH v2] qcow2: Use a GString in report_unsupported_feature()

2020-01-15 Thread Alberto Garcia
This is a bit more efficient than having to allocate and free memory for each item. The default size (60) is enough for all the existing incompatible features or the "Unknown incompatible feature" message. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alberto Garcia Reviewed-by: Alex Benn