Re: [PATCH v2] qapi-gen: mark coroutine QMP command functions as coroutine_fn

2022-10-14 Thread Markus Armbruster
Paolo Bonzini writes: > Coroutine commands have to be declared as coroutine_fn, but the Reminder, because I had to look this up... A "coroutine command" is a command that has flag coroutine set, like so: { 'command': 'block_resize', 'data': { '*device': 'str', '*node-

[PATCH v2] qapi-gen: mark coroutine QMP command functions as coroutine_fn

2022-10-13 Thread Paolo Bonzini
Coroutine commands have to be declared as coroutine_fn, but the marker does not show up in the qapi-comands-* headers; likewise, the marshaling function calls the command and therefore must be coroutine_fn. Static analysis would want coroutine_fn to match between prototype and declaration, because