Re: [PATCH v2] io_uring: fix short read slow path

2022-07-06 Thread Stefan Hajnoczi
On Wed, Jul 06, 2022 at 04:26:59PM +0900, Dominique Martinet wrote: > Stefan Hajnoczi wrote on Wed, Jul 06, 2022 at 08:17:42AM +0100: > > Great! I've already queued your fix. > > Thanks! > > > Do you want to send a follow-up that updates the comment? > > I don't think I'd add much value at this

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-06 Thread Dominique Martinet
Stefan Hajnoczi wrote on Wed, Jul 06, 2022 at 08:17:42AM +0100: > Great! I've already queued your fix. Thanks! > Do you want to send a follow-up that updates the comment? I don't think I'd add much value at this point, leaving it to you unless you really would prefer me to send it. Cheers, --

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-06 Thread Stefan Hajnoczi
On Tue, 5 Jul 2022 at 23:53, Dominique Martinet wrote: > > Stefan Hajnoczi wrote on Tue, Jul 05, 2022 at 02:28:08PM +0100: > > > The older kernel I have installed right now is 5.16 and that can > > > reproduce it -- I'll give my laptop some work over the weekend to test > > > still maintained sta

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-06 Thread Stefan Hajnoczi
On Tue, 5 Jul 2022 at 20:26, Jens Axboe wrote: > > On 7/5/22 7:28 AM, Stefan Hajnoczi wrote: > > On Fri, Jul 01, 2022 at 07:52:31AM +0900, Dominique Martinet wrote: > >> Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > so when we ask for more we issue an extra short reads,

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-05 Thread Dominique Martinet
Stefan Hajnoczi wrote on Tue, Jul 05, 2022 at 02:28:08PM +0100: > > The older kernel I have installed right now is 5.16 and that can > > reproduce it -- I'll give my laptop some work over the weekend to test > > still maintained stable branches if that's useful. > > Linux 5.16 contains commit 9d9

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-05 Thread Jens Axboe
On 7/5/22 7:28 AM, Stefan Hajnoczi wrote: > On Fri, Jul 01, 2022 at 07:52:31AM +0900, Dominique Martinet wrote: >> Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: so when we ask for more we issue an extra short reads, making sure we go through the two short reads path.

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-05 Thread Stefan Hajnoczi
On Thu, Jun 30, 2022 at 10:01:37AM +0900, Dominique Martinet wrote: > sqeq.off here is the offset to read within the disk image, so obviously > not 'nread' (the amount we just read), but as the author meant to write > its current value incremented by the amount we just read. > > Normally recent ve

Re: [PATCH v2] io_uring: fix short read slow path

2022-07-05 Thread Stefan Hajnoczi
On Fri, Jul 01, 2022 at 07:52:31AM +0900, Dominique Martinet wrote: > Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > > > so when we ask for more we issue an extra short reads, making sure we go > > > through the two short reads path. > > > (Unfortunately I wasn't quite sure wh

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Jul 01, 2022 at 07:52:31AM +0900: > Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > > > so when we ask for more we issue an extra short reads, making sure we go > > > through the two short reads path. > > > (Unfortunately I wasn't quite sure wha

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Dominique Martinet
Stefano Garzarella wrote on Thu, Jun 30, 2022 at 05:49:21PM +0200: > > so when we ask for more we issue an extra short reads, making sure we go > > through the two short reads path. > > (Unfortunately I wasn't quite sure what to fiddle with to issue short > > reads in the first place, I tried cutti

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Stefano Garzarella
On Thu, Jun 30, 2022 at 10:01:37AM +0900, Dominique Martinet wrote: sqeq.off here is the offset to read within the disk image, so obviously not 'nread' (the amount we just read), but as the author meant to write its current value incremented by the amount we just read. Normally recent versions o

Re: [PATCH v2] io_uring: fix short read slow path

2022-06-30 Thread Hanna Reitz
On 30.06.22 03:01, Dominique Martinet wrote: sqeq.off here is the offset to read within the disk image, so obviously not 'nread' (the amount we just read), but as the author meant to write its current value incremented by the amount we just read. Normally recent versions of linux will not issue

[PATCH v2] io_uring: fix short read slow path

2022-06-29 Thread Dominique Martinet
sqeq.off here is the offset to read within the disk image, so obviously not 'nread' (the amount we just read), but as the author meant to write its current value incremented by the amount we just read. Normally recent versions of linux will not issue short reads, but it can happen so we should fix