Am 17. Juli 2023 11:03:38 UTC schrieb Olaf Hering :
>Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow :
>
>> The PIIX fix alone just fixes the syptom, not the underlying problem. The
>> underlying problem is that the BAR isn't deactivated, and with the PIIX
>> patch it will stay at address zer
Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow :
> The PIIX fix alone just fixes the syptom, not the underlying problem. The
> underlying problem is that the BAR isn't deactivated, and with the PIIX patch
> it will stay at address zero rather than in the USB function address range.
Did you me
Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow :
> Would you mind sending this patch as well?
Sure, I was waiting for the other change to appear in the master branch,
so I can reference it in the new commit message.
Olaf
pgpICjazXPmwt.pgp
Description: Digitale Signatur von OpenPGP
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering :
>Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini :
>
>> I agree that calling pci_device_reset() would be a better match for
>> pci_xen_ide_unplug().
>
>This change works as well:
>
>--- a/hw/i386/xen/xen_platform.c
>+++ b/hw/i386/xen/xen_platform.
Am 11. Juli 2023 09:11:33 UTC schrieb Olaf Hering :
>Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow :
>
>> I wonder if we should fix this line rather than dropping it.
>
>I think this needs to be fixed, just to fix the initial commit which
>added this bug. This will allow backporting this onel
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering :
>According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS
>MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is
>32bit wide. To properly reset it to default values, all 32bit need to be
>cleared. Bit #0 "Resource Typ
Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow :
> I wonder if we should fix this line rather than dropping it.
I think this needs to be fixed, just to fix the initial commit which
added this bug. This will allow backporting this oneliner.
Further changes to pci_xen_ide_unplug will be done in
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering :
>Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini :
>
>> I agree that calling pci_device_reset() would be a better match for
>> pci_xen_ide_unplug().
>
>This change works as well:
Nice!
>
>--- a/hw/i386/xen/xen_platform.c
>+++ b/hw/i386/xen/xen_p
Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini :
> I agree that calling pci_device_reset() would be a better match for
> pci_xen_ide_unplug().
This change works as well:
--- a/hw/i386/xen/xen_platform.c
+++ b/hw/i386/xen/xen_platform.c
@@ -164,8 +164,9 @@ static void pci_unplug_nics(PCIBus *bus)
On 7/3/23 22:33, Bernhard Beschow wrote:
Paolo, Peter: Should we switch to pci_device_reset() in
pci_xen_ide_unplug()? Or is device_cold_reset() supposed to do
everything?
device_cold_reset() does not reset state that is part of the bus, so I
think it's consistent that it doesn't call pci_do_d
Am 3. Juli 2023 07:59:29 UTC schrieb Olaf Hering :
>Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow :
>
>> Do you know if that command calls pci_device_reset() (which would eventually
>> call piix_ide_reset())?
>
>The function is pci_xen_ide_unplug, which calls device_cold_reset.
I think this
Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow :
> Do you know if that command calls pci_device_reset() (which would eventually
> call piix_ide_reset())?
The function is pci_xen_ide_unplug, which calls device_cold_reset.
Olaf
pgpcLzDeO7ZPB.pgp
Description: Digitale Signatur von OpenPGP
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering :
>According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS
>MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is
>32bit wide. To properly reset it to default values, all 32bit need to be
>cleared. Bit #0 "Resource Typ
According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS
MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is
32bit wide. To properly reset it to default values, all 32bit need to be
cleared. Bit #0 "Resource Type Indicator (RTE)" needs to be enabled.
The initial chang
14 matches
Mail list logo
