Re: [PATCH v2] hw/i386: introduce x86_firmware_reconfigure api

2025-02-28 Thread Gerd Hoffmann
Hi, > +void set_ovmf_flash_parsed_false(void); Hmm, the name literally says what the function does, but gives little background on what is going on. I think something along the lines of 'invalidate_ovmf_metadate' or 'firmware_update_notify' would be better. Otherwise looks good to me. take c

[PATCH v2] hw/i386: introduce x86_firmware_reconfigure api

2025-02-28 Thread Ani Sinha
Normally, there is no need to perform firmware reconfiguration once the virtual machine has started. Hence, currently ovmf firmware parsing happens only once. However, if the firmware changes betweeen boots then reconfiguration needs to happen again. Firmware can change if for example the guest bri