Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-14 Thread Jason Wang
On 2020/7/13 下午8:06, Cédric Le Goater wrote: On 7/7/20 9:42 AM, Erik Smit wrote: Hi Andrew, On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery wrote: On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: The test of the write of the dblac register was testing the old value instead of the new value. Thi

Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-13 Thread Cédric Le Goater
On 7/7/20 9:42 AM, Erik Smit wrote: > Hi Andrew, > > On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery wrote: >> On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: >>> The test of the write of the dblac register was testing the old value >>> instead of the new value. This would accept the write of an inva

Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-07 Thread Erik Smit
Hi Andrew, On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery wrote: > On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: > > The test of the write of the dblac register was testing the old value > > instead of the new value. This would accept the write of an invalid value > > but subsequently refuse any f

Re: [PATCH v2] ftgmac100: fix dblac write test

2020-07-05 Thread Andrew Jeffery
On Sun, 28 Jun 2020, at 23:56, erik-smit wrote: > The test of the write of the dblac register was testing the old value > instead of the new value. This would accept the write of an invalid value > but subsequently refuse any following valid writes. > > Signed-off-by: erik-smit > --- > Changes

[PATCH v2] ftgmac100: fix dblac write test

2020-06-28 Thread erik-smit
The test of the write of the dblac register was testing the old value instead of the new value. This would accept the write of an invalid value but subsequently refuse any following valid writes. Signed-off-by: erik-smit --- Changes since v1: Changed %ld to HWADDR_PRIx to fix building on mingw