Re: [PATCH v2] contrib/plugins/execlog: Fix compiler warning

2024-03-25 Thread Pierrick Bouvier
On 3/25/24 13:58, Peter Maydell wrote: On Mon, 25 Mar 2024 at 06:41, Pierrick Bouvier wrote: On 3/25/24 10:06, Yao Xingtao wrote: diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c index a1dfd59ab7..09654910ee 100644 --- a/contrib/plugins/execlog.c +++ b/contrib/plugins/execlo

Re: [PATCH v2] contrib/plugins/execlog: Fix compiler warning

2024-03-25 Thread Peter Maydell
On Mon, 25 Mar 2024 at 06:41, Pierrick Bouvier wrote: > > On 3/25/24 10:06, Yao Xingtao wrote: > > diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c > > index a1dfd59ab7..09654910ee 100644 > > --- a/contrib/plugins/execlog.c > > +++ b/contrib/plugins/execlog.c > > @@ -327,8 +327,1

Re: [PATCH v2] contrib/plugins/execlog: Fix compiler warning

2024-03-24 Thread Pierrick Bouvier
On 3/25/24 10:06, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is 'gpointer' {aka 'void *'}, but the type of reg->name is

[PATCH v2] contrib/plugins/execlog: Fix compiler warning

2024-03-24 Thread Yao Xingtao via
1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is 'gpointer' {aka 'void *'}, but the type of reg->name is 'const char*'. Cast the type of reg->n