Re: [PATCH v2] block/backup-top: fix flags handling

2020-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2020 19:31, Max Reitz wrote: On 03.02.20 14:42, Vladimir Sementsov-Ogievskiy wrote: backup-top "supports" write-unchanged, by skipping CBW operation in backup_top_co_pwritev. But it forgets to do the same in backup_top_co_pwrite_zeroes, as well as declare support for BDRV_REQ_WRITE_UNCHANG

Re: [PATCH v2] block/backup-top: fix flags handling

2020-02-06 Thread Max Reitz
On 03.02.20 14:42, Vladimir Sementsov-Ogievskiy wrote: > backup-top "supports" write-unchanged, by skipping CBW operation in > backup_top_co_pwritev. But it forgets to do the same in > backup_top_co_pwrite_zeroes, as well as declare support for > BDRV_REQ_WRITE_UNCHANGED. > > Fix this, and, while

Re: [PATCH v2] block/backup-top: fix flags handling

2020-02-03 Thread Vladimir Sementsov-Ogievskiy
03.02.2020 18:42, Eric Blake wrote: On 2/3/20 7:42 AM, Vladimir Sementsov-Ogievskiy wrote: backup-top "supports" write-unchanged, by skipping CBW operation in backup_top_co_pwritev. But it forgets to do the same in backup_top_co_pwrite_zeroes, as well as declare support for BDRV_REQ_WRITE_UNCHAN

Re: [PATCH v2] block/backup-top: fix flags handling

2020-02-03 Thread Eric Blake
On 2/3/20 7:42 AM, Vladimir Sementsov-Ogievskiy wrote: backup-top "supports" write-unchanged, by skipping CBW operation in backup_top_co_pwritev. But it forgets to do the same in backup_top_co_pwrite_zeroes, as well as declare support for BDRV_REQ_WRITE_UNCHANGED. Fix this, and, while being here

[PATCH v2] block/backup-top: fix flags handling

2020-02-03 Thread Vladimir Sementsov-Ogievskiy
backup-top "supports" write-unchanged, by skipping CBW operation in backup_top_co_pwritev. But it forgets to do the same in backup_top_co_pwrite_zeroes, as well as declare support for BDRV_REQ_WRITE_UNCHANGED. Fix this, and, while being here, declare also support for flags supported by source chil