Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 12:35:02PM +0100, Juan Quintela wrote: >> Juan Quintela wrote: >> > "John Berberian, Jr" wrote: >> >> ping. Is there anything I can do to help this get merged? >> > >> > Hi >> > >> > I have to get back from Marc/Daniel before proceed. >> > >> >

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 12:35:02PM +0100, Juan Quintela wrote: > Juan Quintela wrote: > > "John Berberian, Jr" wrote: > >> ping. Is there anything I can do to help this get merged? > > > > Hi > > > > I have to get back from Marc/Daniel before proceed. > > > > You did an answer, but they didn't re

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Juan Quintela
Juan Quintela wrote: > "John Berberian, Jr" wrote: >> ping. Is there anything I can do to help this get merged? > > Hi > > I have to get back from Marc/Daniel before proceed. > > You did an answer, but they didn't respond. > > What should we do here? > > Thanks, Juan. Reviewed-by: Juan Quintela

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 12:11:05PM +0100, Juan Quintela wrote: > "John Berberian, Jr" wrote: > > ping. Is there anything I can do to help this get merged? > > Hi > > I have to get back from Marc/Daniel before proceed. > > You did an answer, but they didn't respond. > > What should we do here?

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Daniel P . Berrangé
On Tue, Jan 31, 2023 at 02:01:07PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 17, 2023 at 9:07 PM John Berberian, Jr > wrote: > > > > Apologies for the late response, I was traveling most of yesterday. > > > > On 1/16/23 4:22 AM, Daniel P. Berrangé wrote: > > > When we introduce a new

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-28 Thread Juan Quintela
"John Berberian, Jr" wrote: > ping. Is there anything I can do to help this get merged? Hi I have to get back from Marc/Daniel before proceed. You did an answer, but they didn't respond. What should we do here? Thanks, Juan. > Best regards, > John Berberian, Jr.

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-02-17 Thread John Berberian, Jr
ping. Is there anything I can do to help this get merged? Best regards, John Berberian, Jr.

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-31 Thread Marc-André Lureau
Hi On Tue, Jan 17, 2023 at 9:07 PM John Berberian, Jr wrote: > > Apologies for the late response, I was traveling most of yesterday. > > On 1/16/23 4:22 AM, Daniel P. Berrangé wrote: > > When we introduce a new QAPI format for migration args though, I've > > suggested we drop support for passing

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-30 Thread John Berberian, Jr.
ping. As requested in the wiki, here's the patchew link: https://patchew.org/QEMU/20230116013421.3149183-1-jeb.st...@gmail.com/

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-17 Thread John Berberian, Jr
Apologies for the late response, I was traveling most of yesterday. On 1/16/23 4:22 AM, Daniel P. Berrangé wrote: When we introduce a new QAPI format for migration args though, I've suggested we drop support for passing exec via shell, and require an explicit argv[] array: https://lists.gnu.

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 11:17:08AM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jan 16, 2023 at 5:35 AM John Berberian, Jr > wrote: > > > > * Use cmd instead of /bin/sh on Windows. > > > > * Try to auto-detect cmd.exe's path, but default to a hard-coded path. > > > > Note that this will requ

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-15 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2023 at 5:35 AM John Berberian, Jr wrote: > > * Use cmd instead of /bin/sh on Windows. > > * Try to auto-detect cmd.exe's path, but default to a hard-coded path. > > Note that this will require that gspawn-win[32|64]-helper.exe and > gspawn-win[32|64]-helper-console.exe are inc

[PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-15 Thread John Berberian, Jr
* Use cmd instead of /bin/sh on Windows. * Try to auto-detect cmd.exe's path, but default to a hard-coded path. Note that this will require that gspawn-win[32|64]-helper.exe and gspawn-win[32|64]-helper-console.exe are included in the Windows binary distributions (cc: Stefan Weil). Signed-off-by