Re: [PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-14 Thread David Hildenbrand
On 14.04.20 00:48, Alexander Duyck wrote: > On Fri, Apr 10, 2020 at 3:50 AM Paolo Bonzini wrote: >> >> On 10/04/20 05:41, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> According to the documentation in memory.h a ROM memory region will be >>> backed by RAM for reads, but is supposed to

Re: [PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-13 Thread Alexander Duyck
On Fri, Apr 10, 2020 at 3:50 AM Paolo Bonzini wrote: > > On 10/04/20 05:41, Alexander Duyck wrote: > > From: Alexander Duyck > > > > According to the documentation in memory.h a ROM memory region will be > > backed by RAM for reads, but is supposed to go through a callback for > > writes. Current

Re: [PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-10 Thread Paolo Bonzini
On 10/04/20 05:41, Alexander Duyck wrote: > From: Alexander Duyck > > According to the documentation in memory.h a ROM memory region will be > backed by RAM for reads, but is supposed to go through a callback for > writes. Currently we were not checking for the existence of the rom_device > flag

[PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck According to the documentation in memory.h a ROM memory region will be backed by RAM for reads, but is supposed to go through a callback for writes. Currently we were not checking for the existence of the rom_device flag when determining if we could perform a direct write or