Re: [PATCH v18 13/14] hw/pci: Use -1 as the default value for rombar

2025-01-05 Thread Philippe Mathieu-Daudé
On 4/1/25 08:52, Akihiko Odaki wrote: vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1 by checking dev->opts, bypassing the QOM property infrastructure. Use -1 as the default value for rombar to tell if the user explicitly set it to 1. The property is also converted from u

[PATCH v18 13/14] hw/pci: Use -1 as the default value for rombar

2025-01-03 Thread Akihiko Odaki
vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1 by checking dev->opts, bypassing the QOM property infrastructure. Use -1 as the default value for rombar to tell if the user explicitly set it to 1. The property is also converted from unsigned to signed. -1 is signed so it is