Re: [PATCH v17 09/16] util/log: Add Error argument to qemu_str_to_log_mask

2023-10-15 Thread Richard Henderson
On 10/10/23 05:55, Markus Armbruster wrote: Richard Henderson writes: Do not rely on return value of 0 to indicate error, pass along an Error pointer to be set. Not wrong, but goes against error.h's recommendation * - Whenever practical, also return a value that indicates success / *

Re: [PATCH v17 09/16] util/log: Add Error argument to qemu_str_to_log_mask

2023-10-10 Thread Markus Armbruster
Richard Henderson writes: > Do not rely on return value of 0 to indicate error, > pass along an Error pointer to be set. Not wrong, but goes against error.h's recommendation * - Whenever practical, also return a value that indicates success / * failure. This can make the error checking mor

[PATCH v17 09/16] util/log: Add Error argument to qemu_str_to_log_mask

2023-10-03 Thread Richard Henderson
Do not rely on return value of 0 to indicate error, pass along an Error pointer to be set. Signed-off-by: Richard Henderson --- include/qemu/log.h | 2 +- bsd-user/main.c| 6 -- linux-user/main.c | 7 +-- monitor/hmp-cmds.c | 5 +++-- softmmu/vl.c | 7 +-- util/log.c