Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > >> Tao Xu writes: > >> > >> > Add do_strtomul() to convert string according to different suffixes. > >> > > >> > Reviewed-by: E

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

Daniel P. Berrangé writes: > On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: >> >> Tao Xu writes: >> >> >> >> > Add do_strtomul() to convert string according to different s

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > >> Tao Xu writes: > >> > >> > Add do_strtomul() to convert string according to different suffixes. > >> > > >> > Reviewed-by: E

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

Tao Xu writes: > Add do_strtomul() to convert string according to different suffixes. > > Reviewed-by: Eduardo Habkost > Signed-off-by: Tao Xu > --- > > No changes in v17. > > Changes in v15: > - Add a new patch to refactor do_strtosz() (Eduardo) > --- > util/cutils.c | 72

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

Eduardo Habkost writes: > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: >> Tao Xu writes: >> >> > Add do_strtomul() to convert string according to different suffixes. >> > >> > Reviewed-by: Eduardo Habkost >> > Signed-off-by: Tao Xu >> >> What's the actual change here?

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > Tao Xu writes: > > > Add do_strtomul() to convert string according to different suffixes. > > > > Reviewed-by: Eduardo Habkost > > Signed-off-by: Tao Xu > > What's the actual change here? "Refactor" suggests the interfaces s

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

Tao Xu writes: > Add do_strtomul() to convert string according to different suffixes. > > Reviewed-by: Eduardo Habkost > Signed-off-by: Tao Xu What's the actual change here? "Refactor" suggests the interfaces stay the same, only their implementation changes. "Support suffixes list" suggests

[PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

Add do_strtomul() to convert string according to different suffixes. Reviewed-by: Eduardo Habkost Signed-off-by: Tao Xu --- No changes in v17. Changes in v15: - Add a new patch to refactor do_strtosz() (Eduardo) --- util/cutils.c | 72 ++- 1