Re: [PATCH v14 04/22] cpu: Move synchronize_from_tb() to tcg_ops

2021-01-28 Thread Richard Henderson
On 1/28/21 8:58 AM, Alex Bennée wrote: > Looking at the function here I wonder if we should be worried about the > thumb state? Peter? > > static void arm_cpu_set_pc(CPUState *cs, vaddr value) > { > ARMCPU *cpu = ARM_CPU(cs); > CPUARMState *env = &cpu->env; > > if (is_a64(env)) { >

Re: [PATCH v14 04/22] cpu: Move synchronize_from_tb() to tcg_ops

2021-01-28 Thread Alex Bennée
Claudio Fontana writes: > From: Eduardo Habkost > > Signed-off-by: Eduardo Habkost > > [claudio: wrapped in CONFIG_TCG] > Signed-off-by: Claudio Fontana > --- > include/hw/core/cpu.h | 20 +++- > accel/tcg/cpu-exec.c | 4 ++-- > target/arm/cpu.c | 4 +++-

[PATCH v14 04/22] cpu: Move synchronize_from_tb() to tcg_ops

2021-01-28 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG] Signed-off-by: Claudio Fontana --- include/hw/core/cpu.h | 20 +++- accel/tcg/cpu-exec.c | 4 ++-- target/arm/cpu.c | 4 +++- target/avr/cpu.c | 2 +- target/hpp