Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-16 Thread Eduardo Habkost
On Mon, Dec 14, 2020 at 05:24:00PM -0500, Eduardo Habkost wrote: > On Mon, Dec 14, 2020 at 10:56:13PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Claudio, Eduardo. > > > > On 12/14/20 8:10 PM, Eduardo Habkost wrote: > > > On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: > > >> From

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-16 Thread Richard Henderson
On 12/16/20 2:44 AM, Claudio Fontana wrote: > Richard, From the answer of Philippe and Eduardo I think they are not ok with > .h.inc, > I think the option of just putting everything in cpu.h was ok with you, > should I go with that? Yes, that would be fine with me. r~

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-16 Thread Claudio Fontana
On 12/14/20 10:56 PM, Philippe Mathieu-Daudé wrote: > Hi Claudio, Eduardo. > > On 12/14/20 8:10 PM, Eduardo Habkost wrote: >> On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: >>> From: Eduardo Habkost >>> >>> since tcg_cpu_ops.h is only included in cpu.h, >>> and as a standalone h

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-14 Thread Eduardo Habkost
On Mon, Dec 14, 2020 at 10:56:13PM +0100, Philippe Mathieu-Daudé wrote: > Hi Claudio, Eduardo. > > On 12/14/20 8:10 PM, Eduardo Habkost wrote: > > On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: > >> From: Eduardo Habkost > >> > >> since tcg_cpu_ops.h is only included in cpu.h, >

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-14 Thread Philippe Mathieu-Daudé
Hi Claudio, Eduardo. On 12/14/20 8:10 PM, Eduardo Habkost wrote: > On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: >> From: Eduardo Habkost >> >> since tcg_cpu_ops.h is only included in cpu.h, >> and as a standalone header it is not really useful, >> as tcg_cpu_ops.h starts requi

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-14 Thread Eduardo Habkost
On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: > From: Eduardo Habkost > > since tcg_cpu_ops.h is only included in cpu.h, > and as a standalone header it is not really useful, > as tcg_cpu_ops.h starts requiring cpu.h defines, > enums, etc, as well as (later on in the series), >

[PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-12 Thread Claudio Fontana
From: Eduardo Habkost since tcg_cpu_ops.h is only included in cpu.h, and as a standalone header it is not really useful, as tcg_cpu_ops.h starts requiring cpu.h defines, enums, etc, as well as (later on in the series), additional definitions coming from memattr.h. Therefore rename it to tcg_cpu_