Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-14 Thread Peter Xu
On Tue, Jan 14, 2020 at 09:37:51AM +0100, Auger Eric wrote: > > In all cases, I see that virtio_iommu_mr() is introduced but not used. > > Would be good to put it into the patch where it's firstly used. > OK fair enough, I will put the helper in the same patch as the user as > you have requested th

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-14 Thread Auger Eric
Hi Peter, On 1/13/20 9:06 PM, Peter Xu wrote: > On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: >> +/** >> + * The bus number is used for lookup when SID based operations occur. >> + * In that case we lazily populate the IOMMUPciBus array from the bus hash >> + * table. At the time the

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-14 Thread Auger Eric
Hi Peter, On 1/13/20 8:53 PM, Peter Xu wrote: > On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: >> Implement a callback called on PCI bus enumeration that >> initializes for a given device on the bus hierarchy >> an IOMMU memory region. The PCI bus hierarchy is stored >> locally in IOM

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: > +/** > + * The bus number is used for lookup when SID based operations occur. > + * In that case we lazily populate the IOMMUPciBus array from the bus hash > + * table. At the time the IOMMUPciBus is created (iommu_find_add_as), the bus

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: > Implement a callback called on PCI bus enumeration that > initializes for a given device on the bus hierarchy > an IOMMU memory region. The PCI bus hierarchy is stored > locally in IOMMUPciBus and IOMMUDevice objects. > > At the time of

[PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-09 Thread Eric Auger
Implement a callback called on PCI bus enumeration that initializes for a given device on the bus hierarchy an IOMMU memory region. The PCI bus hierarchy is stored locally in IOMMUPciBus and IOMMUDevice objects. At the time of the enumeration, the bus number may not be computed yet. So operations