Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-12 Thread Peter Xu
On Thu, Sep 12, 2024 at 11:09:12AM +0300, Avihai Horon wrote: > > On 09/09/2024 18:11, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: > > > On 05/09/2024 21:31, Peter Xu wrote: > > > > Externa

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-12 Thread Cédric Le Goater
On 9/12/24 10:09, Avihai Horon wrote: On 09/09/2024 18:11, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments O

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-12 Thread Avihai Horon
On 09/09/2024 18:11, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 07:45:43PM +030

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-09 Thread Peter Xu
On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: > > On 05/09/2024 21:31, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, Sep 05, 2024 at 07:45:43PM +0300, Avihai Horon wrote: > > > > Does it also mean then that the currently reported

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-09 Thread Avihai Horon
On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 07:45:43PM +0300, Avihai Horon wrote: Does it also mean then that the currently reported stop-size - precopy-size will be very close to the constant non-iterable data size?

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Peter Xu
On Thu, Sep 05, 2024 at 07:45:43PM +0300, Avihai Horon wrote: > > Does it also mean then that the currently reported stop-size - precopy-size > > will be very close to the constant non-iterable data size? > > It's not constant, while the VM is running it can change. I wonder how heavy is VFIO_DEV

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Avihai Horon
On 05/09/2024 19:23, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 07:07:28PM +0300, Avihai Horon wrote: So I wonder why stop-size can change from a driver, and whether that can be reported in a more predictable fashion. Otherwise I see lit

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Peter Xu
On Thu, Sep 05, 2024 at 07:07:28PM +0300, Avihai Horon wrote: > > So I wonder why stop-size can change from a driver, and whether that can be > > reported in a more predictable fashion. Otherwise I see little point in > > providing both stop-size and precopy-size, otherwise we'll always add them >

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Avihai Horon
On 05/09/2024 18:17, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 02:41:09PM +0300, Avihai Horon wrote: On 04/09/2024 19:16, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Sep 04, 2024 at 06:41:03PM +030

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Peter Xu
On Thu, Sep 05, 2024 at 02:41:09PM +0300, Avihai Horon wrote: > > On 04/09/2024 19:16, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, Sep 04, 2024 at 06:41:03PM +0300, Avihai Horon wrote: > > > On 04/09/2024 16:00, Peter Xu wrote: > > > > Externa

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-05 Thread Avihai Horon
On 04/09/2024 19:16, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, Sep 04, 2024 at 06:41:03PM +0300, Avihai Horon wrote: On 04/09/2024 16:00, Peter Xu wrote: External email: Use caution opening links or attachments Hello, Avihai, Reviving this thread ju

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-04 Thread Peter Xu
On Wed, Sep 04, 2024 at 06:41:03PM +0300, Avihai Horon wrote: > > On 04/09/2024 16:00, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > Hello, Avihai, > > > > Reviving this thread just to discuss one issue below.. > > > > On Thu, Feb 16, 2023 at 04:36:27

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-04 Thread Avihai Horon
On 04/09/2024 16:00, Peter Xu wrote: External email: Use caution opening links or attachments Hello, Avihai, Reviving this thread just to discuss one issue below.. On Thu, Feb 16, 2023 at 04:36:27PM +0200, Avihai Horon wrote: +/* + * Migration size of VFIO devices can be as little as a few

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-04 Thread Peter Xu
Hello, Avihai, Reviving this thread just to discuss one issue below.. On Thu, Feb 16, 2023 at 04:36:27PM +0200, Avihai Horon wrote: > +/* > + * Migration size of VFIO devices can be as little as a few KBs or as big as > + * many GBs. This value should be big enough to cover the worst case. > + */

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Alex Williamson
On Thu, 16 Feb 2023 17:52:33 +0100 Juan Quintela wrote: > Avihai Horon wrote: > > On 16/02/2023 17:43, Juan Quintela wrote: > >> External email: Use caution opening links or attachments > >> > >> > >> Avihai Horon wrote: > >> > >> Reviewed-by: Juan Quintela . > >> > >> > >> 1st comment is a b

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Juan Quintela
Avihai Horon wrote: > On 16/02/2023 17:43, Juan Quintela wrote: >> External email: Use caution opening links or attachments >> >> >> Avihai Horon wrote: >> >> Reviewed-by: Juan Quintela . >> >> >> 1st comment is a bug, but as you just remove it. >> >> >> Not that it matters a lot in the end (you

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Avihai Horon
On 16/02/2023 17:43, Juan Quintela wrote: External email: Use caution opening links or attachments Avihai Horon wrote: Reviewed-by: Juan Quintela . 1st comment is a bug, but as you just remove it. Not that it matters a lot in the end (you are removing v1 on the following patch). @@ -4

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Juan Quintela
Avihai Horon wrote: Reviewed-by: Juan Quintela . 1st comment is a bug, but as you just remove it. Not that it matters a lot in the end (you are removing v1 on the following patch). > @@ -438,7 +445,13 @@ static bool > vfio_devices_all_running_and_mig_active(VFIOContainer *container) >

[PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Avihai Horon
Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support VFIO_MIGRATION_STOP_COPY part of the v2 protocol. The two protocols, v1 and v2, will co-exist and in the following patches v1 protocol code will be removed. There are sev