Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-12 Thread Peter Xu
On Mon, May 12, 2025 at 11:56:31AM +0530, Prasad Pandit wrote: > Hi, > > On Fri, 9 May 2025 at 20:41, Peter Xu wrote: > > Isn't that what multifd is doing already? > > typedef struct { > > ... > > /* > > * This array contains the pointers to: > > * - normal pages (initial norma

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-11 Thread Prasad Pandit
Hi, On Fri, 9 May 2025 at 20:41, Peter Xu wrote: > Isn't that what multifd is doing already? > typedef struct { > ... > /* > * This array contains the pointers to: > * - normal pages (initial normal_pages entries) > * - zero pages (following zero_pages entries) > */

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 11:34:06AM +0530, Prasad Pandit wrote: > > > This patch should come before 1/3, otherwise it'll break bisect. > > We could squash the two together, IMHO. > > * It is adjusting the specific optimisation behaviour for the use case > of when Multifd and Postcopy are enabled to

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-09 Thread Prasad Pandit
> > This patch should come before 1/3, otherwise it'll break bisect. > We could squash the two together, IMHO. * It is adjusting the specific optimisation behaviour for the use case of when Multifd and Postcopy are enabled together. I think it's better as a separate patch. It'll help to see how th

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-08 Thread Prasad Pandit
On Thu, 8 May 2025 at 19:27, Fabiano Rosas wrote: > > During multifd migration, zero pages are are written if > > they are migrated more than ones. > > s/ones/once/ > s/ones/once/ > extra blank line here^ > > nit: Inconsistent use of capitalization for the feature names. I'd keep > it all lowercas

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-08 Thread Peter Xu
On Thu, May 08, 2025 at 10:57:19AM -0300, Fabiano Rosas wrote: > Prasad Pandit writes: > > > From: Prasad Pandit > > > > During multifd migration, zero pages are are written if > > they are migrated more than ones. > > s/ones/once/ > > > > > This may result in a migration hang issue when Multi

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-08 Thread Fabiano Rosas
Prasad Pandit writes: > From: Prasad Pandit > > During multifd migration, zero pages are are written if > they are migrated more than ones. s/ones/once/ > > This may result in a migration hang issue when Multifd > and Postcopy are enabled together. > > When Postcopy is enabled, always write ze

[PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-08 Thread Prasad Pandit
From: Prasad Pandit During multifd migration, zero pages are are written if they are migrated more than ones. This may result in a migration hang issue when Multifd and Postcopy are enabled together. When Postcopy is enabled, always write zero pages as and when they are migrated. Signed-off-by