Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-12 Thread Unai Martinez Corral
Laurent, as Eric explained, this commit (as well as the homogeneisation of spacing) are fixes to pre-existing issues in the script, in order to better match other bash sources in the codebase. It would be possible to pick 1/10 and 2/10 as a separate patchset. El mar., 10 mar. 2020 a las 12:47, Eri

Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-10 Thread Eric Blake
On 3/10/20 3:28 AM, Laurent Vivier wrote: Le 09/03/2020 à 20:19, Unai Martinez-Corral a écrit : All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). With the quotes I don't see how we can provoke a syntax error. C

Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-10 Thread Laurent Vivier
Le 09/03/2020 à 20:19, Unai Martinez-Corral a écrit : > All the tests are prefixed with 'x', in order to avoid risky comparisons > (i.e. a user deliberately trying to provoke a syntax error). With the quotes I don't see how we can provoke a syntax error. Could you provide an example? Thanks, Laur

Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-09 Thread Eric Blake
On 3/9/20 2:19 PM, Unai Martinez-Corral wrote: All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 10 +-

[PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

2020-03-09 Thread Unai Martinez-Corral
All the tests are prefixed with 'x', in order to avoid risky comparisons (i.e. a user deliberately trying to provoke a syntax error). Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)