Re: [PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-21 Thread Philippe Mathieu-Daudé
On 15/3/22 15:15, Daniel P. Berrangé wrote: On Tue, Mar 15, 2022 at 01:59:59PM +, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 15/3/22 13:12, Alex Bennée wrote: Another cleanup patch tripped over the fact we weren't being careful in our casting. Fix the casts, allow for a non-co

Re: [PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-15 Thread Peter Maydell
On Tue, 15 Mar 2022 at 14:16, Daniel P. Berrangé wrote: > > On Tue, Mar 15, 2022 at 01:59:59PM +, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > > > On 15/3/22 13:12, Alex Bennée wrote: > > >> Another cleanup patch tripped over the fact we weren't being careful > > >> in our

Re: [PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 01:59:59PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > On 15/3/22 13:12, Alex Bennée wrote: > >> Another cleanup patch tripped over the fact we weren't being careful > >> in our casting. Fix the casts, allow for a non-const and switch from > >> g_re

Re: [PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 15/3/22 13:12, Alex Bennée wrote: >> Another cleanup patch tripped over the fact we weren't being careful >> in our casting. Fix the casts, allow for a non-const and switch from >> g_realloc to g_renew. >> The whole semihosting argument handling could do with

Re: [PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-15 Thread Philippe Mathieu-Daudé
On 15/3/22 13:12, Alex Bennée wrote: Another cleanup patch tripped over the fact we weren't being careful in our casting. Fix the casts, allow for a non-const and switch from g_realloc to g_renew. The whole semihosting argument handling could do with some tests though. Signed-off-by: Alex Benné

[PATCH v1 7/8] semihosting: clean up handling of expanded argv

2022-03-15 Thread Alex Bennée
Another cleanup patch tripped over the fact we weren't being careful in our casting. Fix the casts, allow for a non-const and switch from g_realloc to g_renew. The whole semihosting argument handling could do with some tests though. Signed-off-by: Alex Bennée --- semihosting/config.c | 6 +++---