Re: [PATCH v1 6/7] tests/qtest/migration: Add a wrapper to print test names

2023-11-27 Thread Peter Xu
On Mon, Nov 27, 2023 at 12:44:53PM -0300, Fabiano Rosas wrote: > >> +static void migration_test_wrapper(const void *data) > >> +{ > >> +MigrationTest *test = (MigrationTest *)data; > >> + > >> +g_test_message("Running /%s%s", qtest_get_arch(), test->name); > > > > /%s/%s? > > The test name

Re: [PATCH v1 6/7] tests/qtest/migration: Add a wrapper to print test names

2023-11-27 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Nov 24, 2023 at 01:14:31PM -0300, Fabiano Rosas wrote: >> Our usage of gtest results in us losing the very basic functionality >> of "knowing which test failed". The issue is that gtest only prints >> test names ("paths" in gtest parlance) once the test has finished, bu

Re: [PATCH v1 6/7] tests/qtest/migration: Add a wrapper to print test names

2023-11-27 Thread Peter Xu
On Fri, Nov 24, 2023 at 01:14:31PM -0300, Fabiano Rosas wrote: > Our usage of gtest results in us losing the very basic functionality > of "knowing which test failed". The issue is that gtest only prints > test names ("paths" in gtest parlance) once the test has finished, but > we use asserts in th

[PATCH v1 6/7] tests/qtest/migration: Add a wrapper to print test names

2023-11-24 Thread Fabiano Rosas
Our usage of gtest results in us losing the very basic functionality of "knowing which test failed". The issue is that gtest only prints test names ("paths" in gtest parlance) once the test has finished, but we use asserts in the tests and crash gtest itself before it can print anything. We also us