Re: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-27 Thread Peter Xu
On Mon, Nov 27, 2023 at 05:32:45PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Nov 27, 2023 at 12:52:38PM -0300, Fabiano Rosas wrote: > >> >> @@ -118,6 +118,12 @@ void migrate_incoming_qmp(QTestState *to, const > >> >> char *uri, const char *fmt, ...) > >> >> > >> >> rsp

Re: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-27 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 27, 2023 at 12:52:38PM -0300, Fabiano Rosas wrote: >> >> @@ -118,6 +118,12 @@ void migrate_incoming_qmp(QTestState *to, const char >> >> *uri, const char *fmt, ...) >> >> >> >> rsp = qtest_qmp(to, "{ 'execute': 'migrate-incoming', 'arguments': >> >> %p}", >

Re: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-27 Thread Peter Xu
On Mon, Nov 27, 2023 at 12:52:38PM -0300, Fabiano Rosas wrote: > >> @@ -118,6 +118,12 @@ void migrate_incoming_qmp(QTestState *to, const char > >> *uri, const char *fmt, ...) > >> > >> rsp = qtest_qmp(to, "{ 'execute': 'migrate-incoming', 'arguments': > >> %p}", > >> a

Re: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-27 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Nov 24, 2023 at 01:14:30PM -0300, Fabiano Rosas wrote: >> We're currently just asserting when incoming migration fails. Let's >> print the error message from QMP as well. >> >> Signed-off-by: Fabiano Rosas >> --- >> tests/qtest/migration-helpers.c | 6 ++ >> 1 fi

Re: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-27 Thread Peter Xu
On Fri, Nov 24, 2023 at 01:14:30PM -0300, Fabiano Rosas wrote: > We're currently just asserting when incoming migration fails. Let's > print the error message from QMP as well. > > Signed-off-by: Fabiano Rosas > --- > tests/qtest/migration-helpers.c | 6 ++ > 1 file changed, 6 insertions(+)

[PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors

2023-11-24 Thread Fabiano Rosas
We're currently just asserting when incoming migration fails. Let's print the error message from QMP as well. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-helpers.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers