Re: [PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Richard Henderson
On 3/27/20 2:49 AM, Alex Bennée wrote: > It's perfectly possible to have no function symbols in your elf file > and if we do the undefined behaviour sanitizer rightly complains about > us passing NULL to qsort. Check nsyms before we go ahead. > > Signed-off-by: Alex Bennée > --- > include/hw/elf

Re: [PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Peter Maydell
On Fri, 27 Mar 2020 at 09:50, Alex Bennée wrote: > > It's perfectly possible to have no function symbols in your elf file > and if we do the undefined behaviour sanitizer rightly complains about > us passing NULL to qsort. Check nsyms before we go ahead. > > Signed-off-by: Alex Bennée > --- > in

Re: [PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Philippe Mathieu-Daudé
On 3/27/20 11:53 AM, Philippe Mathieu-Daudé wrote: On 3/27/20 10:49 AM, Alex Bennée wrote: It's perfectly possible to have no function symbols in your elf file and if we do the undefined behaviour sanitizer rightly complains about us passing NULL to qsort. Check nsyms before we go ahead. Signed

Re: [PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Philippe Mathieu-Daudé
On 3/27/20 10:49 AM, Alex Bennée wrote: It's perfectly possible to have no function symbols in your elf file and if we do the undefined behaviour sanitizer rightly complains about us passing NULL to qsort. Check nsyms before we go ahead. Signed-off-by: Alex Bennée --- include/hw/elf_ops.h | 7

[PATCH v1 1/7] elf-ops: bail out if we have no function symbols

2020-03-27 Thread Alex Bennée
It's perfectly possible to have no function symbols in your elf file and if we do the undefined behaviour sanitizer rightly complains about us passing NULL to qsort. Check nsyms before we go ahead. Signed-off-by: Alex Bennée --- include/hw/elf_ops.h | 7 ++- 1 file changed, 6 insertions(+),