Re: [PATCH v1 1/1] hw/gpio: Add ASPEED GPIO model for AST1030

2022-05-24 Thread Jamin Lin
The 05/11/2022 06:14, Cédric Le Goater wrote: Hi Cerdic, > Hello Jamin, > > (Adding a few people that could help with the review) > > On 3/21/22 10:14, Jamin Lin wrote: > > > 1. Add GPIO read/write trace event. > > Do we really need the "DEVICE(s)->canonical_path" parameter ? > That would be pa

Re: [PATCH v1 1/1] hw/gpio: Add ASPEED GPIO model for AST1030

2022-05-10 Thread Cédric Le Goater
Hello Jamin, (Adding a few people that could help with the review) On 3/21/22 10:14, Jamin Lin wrote: 1. Add GPIO read/write trace event. Do we really need the "DEVICE(s)->canonical_path" parameter ? That would be patch 1. 2. Support GPIO index mode for write operation. It did not support

[PATCH v1 1/1] hw/gpio: Add ASPEED GPIO model for AST1030

2022-03-21 Thread Jamin Lin
1. Add GPIO read/write trace event. 2. Support GPIO index mode for write operation. It did not support GPIO index mode for read operation. 3. AST1030 integrates one set of Parallel GPIO Controller with maximum 151 control pins, which are 21 groups (A~U, exclude pin: M6 M7 Q5 Q6 Q7 R0 R1 R4 R5 R6 R7