Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-18 Thread David Hildenbrand
On 15.05.20 20:36, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 15.05.20 19:51, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: On 15.05.20 14:45, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) w

Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-15 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 15.05.20 19:51, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> On 15.05.20 14:45, Dr. David Alan Gilbert wrote: > >>> * David Hildenbrand (da...@redhat.com) wrote: > RDMA will pin all guest memory (as docu

Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-15 Thread David Hildenbrand
On 15.05.20 19:51, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 15.05.20 14:45, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: RDMA will pin all guest memory (as documented in docs/rdma.txt). We want to mark RAM block

Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-15 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 15.05.20 14:45, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> RDMA will pin all guest memory (as documented in docs/rdma.txt). We want > >> to mark RAM block discards to be broken - however, to keep it simple

Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-15 Thread David Hildenbrand
On 15.05.20 14:45, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> RDMA will pin all guest memory (as documented in docs/rdma.txt). We want >> to mark RAM block discards to be broken - however, to keep it simple >> use ram_block_discard_is_required() instead of inhi

Re: [PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-15 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > RDMA will pin all guest memory (as documented in docs/rdma.txt). We want > to mark RAM block discards to be broken - however, to keep it simple > use ram_block_discard_is_required() instead of inhibiting. Should this be dependent on whether rdma->pin

[PATCH v1 07/17] migration/rdma: Use ram_block_discard_set_broken()

2020-05-06 Thread David Hildenbrand
RDMA will pin all guest memory (as documented in docs/rdma.txt). We want to mark RAM block discards to be broken - however, to keep it simple use ram_block_discard_is_required() instead of inhibiting. Cc: "Michael S. Tsirkin" Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Signed-off-by: David H