Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-22 Thread Peter Maydell
On Fri, 22 May 2020 at 11:24, Alex Bennée wrote: > Examples: > > /tmp/qemu-test/src/fpu/softfloat.c:3365:13: error: bitwise negation of a > boolean expression; did you mean logical negation? [-Werror,-Wbool-operation] > absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven ); >

Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-22 Thread Alex Bennée
Richard Henderson writes: > On 5/21/20 1:21 AM, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> On 13/05/2020 19.51, Alex Bennée wrote: First we ensure all guest space initialisation logic comes through probe_guest_base once we understand the nature of the binary we are lo

Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-21 Thread Richard Henderson
On 5/21/20 1:21 AM, Alex Bennée wrote: > > Thomas Huth writes: > >> On 13/05/2020 19.51, Alex Bennée wrote: >>> First we ensure all guest space initialisation logic comes through >>> probe_guest_base once we understand the nature of the binary we are >>> loading. The convoluted init_guest_space

Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-21 Thread Alex Bennée
Thomas Huth writes: > On 13/05/2020 19.51, Alex Bennée wrote: >> First we ensure all guest space initialisation logic comes through >> probe_guest_base once we understand the nature of the binary we are >> loading. The convoluted init_guest_space routine is removed and >> replaced with a number

Re: [PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-20 Thread Thomas Huth
On 13/05/2020 19.51, Alex Bennée wrote: > First we ensure all guest space initialisation logic comes through > probe_guest_base once we understand the nature of the binary we are > loading. The convoluted init_guest_space routine is removed and > replaced with a number of pgb_* helpers which are ca

[PATCH v1 04/10] linux-user: completely re-write init_guest_space

2020-05-13 Thread Alex Bennée
First we ensure all guest space initialisation logic comes through probe_guest_base once we understand the nature of the binary we are loading. The convoluted init_guest_space routine is removed and replaced with a number of pgb_* helpers which are called depending on what requirements we have when