Corey Minyard writes:
> On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
>> Hello,
>>
>> This is the type of cleanup I've contributed to Libvirt
>> during the last year. Figured QEMU also deserves the same
>> care.
>>
>> The idea here is remove unneeded labels. By 'unnee
On 1/10/20 4:05 PM, Eric Blake wrote:
On 1/6/20 12:23 PM, Daniel Henrique Barboza wrote:
Hello,
This is the type of cleanup I've contributed to Libvirt
during the last year. Figured QEMU also deserves the same
care.
The idea here is remove unneeded labels. By 'unneeded' I
mean labels that d
On 1/6/20 12:23 PM, Daniel Henrique Barboza wrote:
Hello,
This is the type of cleanup I've contributed to Libvirt
during the last year. Figured QEMU also deserves the same
care.
The idea here is remove unneeded labels. By 'unneeded' I
mean labels that does nothing but a 'return' call. One
commo
On 1/7/20 6:43 AM, Max Reitz wrote:
On 06.01.20 19:23, Daniel Henrique Barboza wrote:
[...]
For me, it doesn’t require any brain cycles, because I generally just
assume the cleanup label will do the right thing. OTOH, a return
statement may make me invest some some brain cycles, because
On 1/7/20 4:06 AM, Philippe Mathieu-Daudé wrote:
On 1/7/20 7:16 AM, Kevin Wolf wrote:
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
On 1/6/20 4:54 PM, Corey Minyard wrote:
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
Hello,
[...]
Which is cl
Am 07.01.2020 um 12:52 hat Daniel Henrique Barboza geschrieben:
> > So what is your plan for getting the series merged? Should maintainers
> > just picks patches from the series, or do you want to collect Acked-by
> > tags and then merge it through a single tree? If the latter, which one?
>
> The
On 1/7/20 3:16 AM, Kevin Wolf wrote:
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
[...]
So what is your plan for getting the series merged? Should maintainers
just picks patches from the series, or do you want to collect Acked-by
tags and then merge it through a singl
On 06.01.20 19:23, Daniel Henrique Barboza wrote:
> Hello,
>
> This is the type of cleanup I've contributed to Libvirt
> during the last year. Figured QEMU also deserves the same
> care.
>
> The idea here is remove unneeded labels. By 'unneeded' I
> mean labels that does nothing but a 'return' ca
On 1/7/20 7:16 AM, Kevin Wolf wrote:
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
On 1/6/20 4:54 PM, Corey Minyard wrote:
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
Hello,
[...]
Which is cleaner and requires less brain cycles to wonder
whethe
Am 06.01.2020 um 21:35 hat Daniel Henrique Barboza geschrieben:
>
>
> On 1/6/20 4:54 PM, Corey Minyard wrote:
> > On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
> > > Hello,
> [...]
> > >
> > > Which is cleaner and requires less brain cycles to wonder
> > > whether the
On 1/6/20 4:54 PM, Corey Minyard wrote:
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
Hello,
[...]
Which is cleaner and requires less brain cycles to wonder
whether the 'cleanup' label does anything special, such
as a heap memory cleanup.
I would disagree with
On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote:
> Hello,
>
> This is the type of cleanup I've contributed to Libvirt
> during the last year. Figured QEMU also deserves the same
> care.
>
> The idea here is remove unneeded labels. By 'unneeded' I
> mean labels that does no
Hello,
This is the type of cleanup I've contributed to Libvirt
during the last year. Figured QEMU also deserves the same
care.
The idea here is remove unneeded labels. By 'unneeded' I
mean labels that does nothing but a 'return' call. One
common case is something like this:
if ()
goto cleanu
13 matches
Mail list logo
