Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-02 Thread Xiaoyao Li
On 8/2/2024 12:46 AM, Manish wrote: On 01/08/24 8:41 pm, Xiaoyao Li wrote: !---|  CAUTION: External Email |---! On 8/1/2024 6:25 PM, Igor Mammedov wrote: On Thu, 1

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Zhao Liu
On Wed, Jul 31, 2024 at 07:30:44PM +0530, Manish wrote: > Date: Wed, 31 Jul 2024 19:30:44 +0530 > From: Manish > Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f > > > On 30/07/24 6:39 pm, I

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Manish
On 01/08/24 8:41 pm, Xiaoyao Li wrote: !---|  CAUTION: External Email |---! On 8/1/2024 6:25 PM, Igor Mammedov wrote: On Thu, 1 Aug 2024 15:36:10 +0530 Manish wrot

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Xiaoyao Li
On 8/1/2024 6:25 PM, Igor Mammedov wrote: On Thu, 1 Aug 2024 15:36:10 +0530 Manish wrote: On 31/07/24 9:01 pm, Xiaoyao Li wrote: !---|  CAUTION: External Email |--

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Igor Mammedov
On Thu, 1 Aug 2024 15:36:10 +0530 Manish wrote: > On 31/07/24 9:01 pm, Xiaoyao Li wrote: > > !---| > >  CAUTION: External Email > > > > |---! > > > > On 7/31/2024 4:49 P

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Manish
On 31/07/24 9:01 pm, Xiaoyao Li wrote: !---|  CAUTION: External Email |---! On 7/31/2024 4:49 PM, John Levon wrote: On Wed, Jul 31, 2024 at 03:02:15PM +0800, Xiaoya

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread Xiaoyao Li
On 7/31/2024 4:49 PM, John Levon wrote: On Wed, Jul 31, 2024 at 03:02:15PM +0800, Xiaoyao Li wrote: Windows does not expect 0x1f to be present for any CPU model. But if it is exposed to the guest, it expects non-zero values. Please fix Windows! A ticket has been filed with MSFT, we are awar

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread Manish
Mammedov wrote: Date: Wed, 24 Jul 2024 14:54:32 +0200 From: Igor Mammedov Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) On Wed, 24 Jul 2024 12:13:28 +0100 John Levon wrote: On Wed, Jul 24, 2024 at 03:59:29PM +0530

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread John Levon
On Wed, Jul 31, 2024 at 03:02:15PM +0800, Xiaoyao Li wrote: > > Windows does not expect 0x1f to be present for any CPU model. But if it > > is exposed to the guest, it expects non-zero values. > > Please fix Windows! A ticket has been filed with MSFT, we are aware this is a guest bug. But that

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-31 Thread Xiaoyao Li
On 7/24/2024 6:29 PM, Manish wrote: Thanks Igor On 24/07/24 2:30 pm, Igor Mammedov wrote: !---|    CAUTION: External Email |---! On Wed, 24 Jul 2024 07:52:26 + "

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-30 Thread Igor Mammedov
---! > > > > On Wed, 24 Jul 2024 23:00:13 +0800 > > Zhao Liu wrote: > > > >> Hi Igor, > >> > >> On Wed, Jul 24, 2024 at 02:54:32PM +0200, Igor Mammedov wrote: > >>> Date: Wed, 24 Jul 2024 14:54:32 +0200 > >>> From: Igo

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-29 Thread Manish
, 2024 at 02:54:32PM +0200, Igor Mammedov wrote: Date: Wed, 24 Jul 2024 14:54:32 +0200 From: Igor Mammedov Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) On Wed, 24 Jul 2024 12:13:28 +0100 John Levon wrote: On Wed, Jul

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-29 Thread Igor Mammedov
On Wed, 24 Jul 2024 23:00:13 +0800 Zhao Liu wrote: > Hi Igor, > > On Wed, Jul 24, 2024 at 02:54:32PM +0200, Igor Mammedov wrote: > > Date: Wed, 24 Jul 2024 14:54:32 +0200 > > From: Igor Mammedov > > Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f > >

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-28 Thread Manish
at 02:54:32PM +0200, Igor Mammedov wrote: Date: Wed, 24 Jul 2024 14:54:32 +0200 From: Igor Mammedov Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) On Wed, 24 Jul 2024 12:13:28 +0100 John Levon wrote: On Wed, Jul 24

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread Zhao Liu
Hi Igor, On Wed, Jul 24, 2024 at 02:54:32PM +0200, Igor Mammedov wrote: > Date: Wed, 24 Jul 2024 14:54:32 +0200 > From: Igor Mammedov > Subject: Re: [PATCH v1] target/i386: Always set leaf 0x1f > X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) > > On Wed, 24

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread Manish
On 24/07/24 6:24 pm, Igor Mammedov wrote: !---| CAUTION: External Email |---! On Wed, 24 Jul 2024 12:13:28 +0100 John Levon wrote: On Wed, Jul 24, 2024 at 03:5

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2024 12:13:28 +0100 John Levon wrote: > On Wed, Jul 24, 2024 at 03:59:29PM +0530, Manish wrote: > > > > > Leaf 0x1f is superset of 0xb, so it makes sense to set 0x1f equivalent > > > > to 0xb by default and workaround windows issue.> > > > > This change adds a > > > > new property

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread Manish
On 24/07/24 4:43 pm, John Levon wrote: On Wed, Jul 24, 2024 at 03:59:29PM +0530, Manish wrote: Leaf 0x1f is superset of 0xb, so it makes sense to set 0x1f equivalent to 0xb by default and workaround windows issue.> This change adds a new property 'cpuid-0x1f-enforce' to set leaf 0x1f equivale

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread John Levon
On Wed, Jul 24, 2024 at 03:59:29PM +0530, Manish wrote: > > > Leaf 0x1f is superset of 0xb, so it makes sense to set 0x1f equivalent > > > to 0xb by default and workaround windows issue.> > > > This change adds a > > > new property 'cpuid-0x1f-enforce' to set leaf 0x1f equivalent to 0xb in > > > c

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2024 07:52:26 + "manish.mishra" wrote: > From: Manish Mishra > > QEMU does not set 0x1f in case VM does not have extended CPU topology > and expects guests to fallback to 0xb. Some versions of Windows does not > like this behavior and expects this leaf to be populated. As a r

[PATCH v1] target/i386: Always set leaf 0x1f

2024-07-24 Thread manish.mishra
From: Manish Mishra QEMU does not set 0x1f in case VM does not have extended CPU topology and expects guests to fallback to 0xb. Some versions of Windows does not like this behavior and expects this leaf to be populated. As a result Windows VM fails with blue screen. Leaf 0x1f is superset of 0xb