RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-23 Thread Wang, Wei W
On Tuesday, May 23, 2023 10:50 PM, Peter Xu wrote: > On Tue, May 23, 2023 at 02:30:25PM +, Wang, Wei W wrote: > > > It's about whether we want to protect e.g. below steps: > > > > > > 1. start dest qemu with -incoming defer 2. > > > "migrate-set-capabilities" to enable multifd 3. "migrate-incom

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-23 Thread Peter Xu
On Tue, May 23, 2023 at 02:30:25PM +, Wang, Wei W wrote: > > It's about whether we want to protect e.g. below steps: > > > > 1. start dest qemu with -incoming defer > > 2. "migrate-set-capabilities" to enable multifd > > 3. "migrate-incoming xxx" to setup the sockets > > 4. "migrate-set-parame

RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-23 Thread Wang, Wei W
On Tuesday, May 23, 2023 9:41 PM, Peter Xu wrote: > On Tue, May 23, 2023 at 01:44:03AM +, Wang, Wei W wrote: > > On Tuesday, May 23, 2023 7:36 AM, Peter Xu wrote: > > > > > We may also want to trap the channel setups on num: > > > > > > > > > > migrate_params_test_apply(): > > > > > > > > > >

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-23 Thread Peter Xu
On Tue, May 23, 2023 at 01:44:03AM +, Wang, Wei W wrote: > On Tuesday, May 23, 2023 7:36 AM, Peter Xu wrote: > > > > We may also want to trap the channel setups on num: > > > > > > > > migrate_params_test_apply(): > > > > > > > > if (params->has_multifd_channels) { > > > > dest->mul

RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-22 Thread Wang, Wei W
On Tuesday, May 23, 2023 7:36 AM, Peter Xu wrote: > > > We may also want to trap the channel setups on num: > > > > > > migrate_params_test_apply(): > > > > > > if (params->has_multifd_channels) { > > > dest->multifd_channels = params->multifd_channels; > > > } > > > > Didn’t get th

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-22 Thread Peter Xu
On Sat, May 20, 2023 at 01:42:06AM +, Wang, Wei W wrote: > On Friday, May 19, 2023 11:34 PM, Peter Xu wrote: > > > Ah yes indeed it keeps working, because we apply -global bits before > > > setup sockets. Then it's fine by me since that's the only thing I > > > would still like to keep it worki

RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Wang, Wei W
On Friday, May 19, 2023 11:34 PM, Peter Xu wrote: > > Ah yes indeed it keeps working, because we apply -global bits before > > setup sockets. Then it's fine by me since that's the only thing I > > would still like to keep it working. :) > > > > If so, can we reword the error message a bit? Obvious

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Peter Xu
On Fri, May 19, 2023 at 11:30:31AM -0400, Peter Xu wrote: > On Fri, May 19, 2023 at 02:34:57AM +, Wang, Wei W wrote: > > On Friday, May 19, 2023 3:20 AM, Peter Xu wrote: > > > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > > > qemu_start_incoming_migration needs to check the numb

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Peter Xu
On Fri, May 19, 2023 at 09:26:23AM +0100, Daniel P. Berrangé wrote: > On Thu, May 18, 2023 at 03:20:02PM -0400, Peter Xu wrote: > > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > > qemu_start_incoming_migration needs to check the number of multifd > > > channels or postcopy ram chann

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Peter Xu
On Fri, May 19, 2023 at 02:34:57AM +, Wang, Wei W wrote: > On Friday, May 19, 2023 3:20 AM, Peter Xu wrote: > > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > > qemu_start_incoming_migration needs to check the number of multifd > > > channels or postcopy ram channels to configure

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Daniel P . Berrangé
On Thu, May 18, 2023 at 03:20:02PM -0400, Peter Xu wrote: > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > qemu_start_incoming_migration needs to check the number of multifd > > channels or postcopy ram channels to configure the backlog parameter (i.e. > > the maximum length to which

RE: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-18 Thread Wang, Wei W
On Friday, May 19, 2023 3:20 AM, Peter Xu wrote: > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > qemu_start_incoming_migration needs to check the number of multifd > > channels or postcopy ram channels to configure the backlog parameter (i.e. > > the maximum length to which the queu

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-18 Thread Peter Xu
On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > qemu_start_incoming_migration needs to check the number of multifd > channels or postcopy ram channels to configure the backlog parameter (i.e. > the maximum length to which the queue of pending connections for sockfd > may grow) of listen

[PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-18 Thread Wei Wang
qemu_start_incoming_migration needs to check the number of multifd channels or postcopy ram channels to configure the backlog parameter (i.e. the maximum length to which the queue of pending connections for sockfd may grow) of listen(). So multifd and postcopy-preempt caps require the use of deferr