Re: [PATCH qemu.git v2 3/9] hw/timer/imx_epit: simplify interrupt logic

2022-11-21 Thread Axel Heider
Having an "update interrupt" function is the more common convention in QEMU device models -- it means you have one function you can call from any point where you've updated any of the state that affects whether an interrupt is generated or not. Ok, will keept it. For instance there's curre

Re: [PATCH qemu.git v2 3/9] hw/timer/imx_epit: simplify interrupt logic

2022-11-18 Thread Peter Maydell
On Mon, 7 Nov 2022 at 16:42, ~axelheider wrote: > > From: Axel Heider > > Signed-off-by: Axel Heider > --- > hw/timer/imx_epit.c | 27 +++ > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c > index 8ec770f674..2

[PATCH qemu.git v2 3/9] hw/timer/imx_epit: simplify interrupt logic

2022-11-07 Thread ~axelheider
From: Axel Heider Signed-off-by: Axel Heider --- hw/timer/imx_epit.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c index 8ec770f674..2e9dae0bc8 100644 --- a/hw/timer/imx_epit.c +++ b/hw/timer/imx_epit.