Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-27 Thread Alexey Kardashevskiy
On 6/28/22 04:04, Daniel Henrique Barboza wrote: On 6/27/22 01:54, Alexey Kardashevskiy wrote: On 6/25/22 06:12, Daniel Henrique Barboza wrote: Alexey, The newer version of this patch is having trouble with Gitlab runners, as you can read in my feedback there. I've tested this one ju

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-27 Thread Daniel Henrique Barboza
On 6/27/22 01:54, Alexey Kardashevskiy wrote: On 6/25/22 06:12, Daniel Henrique Barboza wrote: Alexey, The newer version of this patch is having trouble with Gitlab runners, as you can read in my feedback there. I've tested this one just in case. The same problems happen. E.g. for the cro

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-27 Thread Daniel Henrique Barboza
On 6/27/22 01:54, Alexey Kardashevskiy wrote: On 6/25/22 06:12, Daniel Henrique Barboza wrote: Alexey, The newer version of this patch is having trouble with Gitlab runners, as you can read in my feedback there. I've tested this one just in case. The same problems happen. E.g. for the cro

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-26 Thread Alexey Kardashevskiy
On 6/25/22 06:12, Daniel Henrique Barboza wrote: Alexey, The newer version of this patch is having trouble with Gitlab runners, as you can read in my feedback there. I've tested this one just in case. The same problems happen. E.g. for the cross-armel-system runner: In file included from .

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-24 Thread Daniel Henrique Barboza
Alexey, The newer version of this patch is having trouble with Gitlab runners, as you can read in my feedback there. I've tested this one just in case. The same problems happen. E.g. for the cross-armel-system runner: In file included from ../hw/intc/pnv_xive.c:14: ../hw/intc/pnv_xive.c: In fu

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-21 Thread Peter Maydell
On Fri, 17 Jun 2022 at 07:20, Alexey Kardashevskiy wrote: > > It keeps repeating, move it to the header. This uses __builtin_ctzl() to > allow using the macros in #define. > > Signed-off-by: Alexey Kardashevskiy > --- > include/hw/pci-host/pnv_phb3_regs.h | 16 > target/ppc/cpu.

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-21 Thread Daniel Henrique Barboza
On 6/20/22 05:10, Alexey Kardashevskiy wrote: On 6/20/22 16:17, Cédric Le Goater wrote: On 6/20/22 05:37, Alexey Kardashevskiy wrote: On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-20 Thread Alexey Kardashevskiy
On 6/20/22 16:17, Cédric Le Goater wrote: On 6/20/22 05:37, Alexey Kardashevskiy wrote: On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #def

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-19 Thread Cédric Le Goater
On 6/20/22 05:37, Alexey Kardashevskiy wrote: On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy ---

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-19 Thread Alexey Kardashevskiy
On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy --- Reviewed-by: Daniel Henrique Barboza so

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-18 Thread Cédric Le Goater
On 6/17/22 08:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Cédric Le Goater Thanks Alexey, C. --- include/hw/pci-host/pnv_phb3_regs.h | 16 --

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-17 Thread Daniel Henrique Barboza
On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy --- Reviewed-by: Daniel Henrique Barboza include/hw/pci-host/pnv_phb3_regs.h | 16

[PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-16 Thread Alexey Kardashevskiy
It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy --- include/hw/pci-host/pnv_phb3_regs.h | 16 target/ppc/cpu.h| 5 + hw/intc/pnv_xive.c | 20