Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-09 Thread Alexey Kardashevskiy
On 10/03/2021 13:40, David Gibson wrote: On Wed, Mar 10, 2021 at 12:55:07PM +1100, Alexey Kardashevskiy wrote: On 10/03/2021 01:00, BALATON Zoltan wrote: On Tue, 9 Mar 2021, Alexey Kardashevskiy wrote: On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +   

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-09 Thread David Gibson
On Tue, Mar 09, 2021 at 06:28:44PM +1100, Alexey Kardashevskiy wrote: > > > On 09/03/2021 16:29, David Gibson wrote: > > > > > > > +struct ClientArchitectureSupportClass { > > > > > +InterfaceClass parent; > > > > > +target_ulong (*cas)(CPUState *cs, target_ulong vec); > > > > > +vo

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-09 Thread David Gibson
On Wed, Mar 10, 2021 at 12:55:07PM +1100, Alexey Kardashevskiy wrote: > > > On 10/03/2021 01:00, BALATON Zoltan wrote: > > On Tue, 9 Mar 2021, Alexey Kardashevskiy wrote: > > > On 09/03/2021 16:29, David Gibson wrote: > > > > > > > +struct ClientArchitectureSupportClass { > > > > > > > +    Inter

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-09 Thread Alexey Kardashevskiy
On 10/03/2021 01:00, BALATON Zoltan wrote: On Tue, 9 Mar 2021, Alexey Kardashevskiy wrote: On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +    InterfaceClass parent; +    target_ulong (*cas)(CPUState *cs, target_ulong vec); +    void (*quiesce)(void); Is

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-09 Thread BALATON Zoltan
On Tue, 9 Mar 2021, Alexey Kardashevskiy wrote: On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +InterfaceClass parent; +target_ulong (*cas)(CPUState *cs, target_ulong vec); +void (*quiesce)(void); Is there actually any real connection of quiesce b

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread Alexey Kardashevskiy
On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +InterfaceClass parent; +target_ulong (*cas)(CPUState *cs, target_ulong vec); +void (*quiesce)(void); Is there actually any real connection of quiesce behaviour to cas behaviour? Basically, I'm w

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread David Gibson
On Tue, Mar 02, 2021 at 06:21:51PM +1100, Alexey Kardashevskiy wrote: > > > On 02/03/2021 14:35, David Gibson wrote: > > On Wed, Feb 24, 2021 at 04:41:30PM +1100, Alexey Kardashevskiy wrote: > > > The PAPR platform which describes an OS environment that's presented by > > > a combination of a hyp

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-08 Thread David Gibson
On Tue, Mar 02, 2021 at 10:37:59AM +0100, BALATON Zoltan wrote: > On Tue, 2 Mar 2021, Alexey Kardashevskiy wrote: > > On 02/03/2021 14:35, David Gibson wrote: > > > Alexey or Zoltan, any thoughts on how non-PAPR versions of this would > > > call into qemu to get the non-guest parts of VOF to execut

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-02 Thread BALATON Zoltan
On Tue, 2 Mar 2021, Alexey Kardashevskiy wrote: On 02/03/2021 14:35, David Gibson wrote: Alexey or Zoltan, any thoughts on how non-PAPR versions of this would call into qemu to get the non-guest parts of VOF to execute? Non-PAPR could do it as we do it for soft breakpoints in KVM - some prede

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-01 Thread Alexey Kardashevskiy
On 02/03/2021 14:35, David Gibson wrote: On Wed, Feb 24, 2021 at 04:41:30PM +1100, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmwa

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-01 Thread David Gibson
On Wed, Feb 24, 2021 at 04:41:30PM +1100, Alexey Kardashevskiy wrote: > The PAPR platform which describes an OS environment that's presented by > a combination of a hypervisor and firmware. The features it specifies > require collaboration between the firmware and the hypervisor. > > Since the beg

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-03-01 Thread David Gibson
> Type: series > Message-id: 20210224054130.4540-1-...@ozlabs.ru > Subject: [PATCH qemu v14] spapr: Implement Open Firmware client interface > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 >

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210224054130.4540-1-...@ozlabs.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210224054130.4540-1-...@ozlabs.ru Subject: [PATCH qemu v14] spapr: Implement Open Firmware

[PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-02-23 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2